[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu
Subject: Re: Review Request 123968: Simplify Finding GSL in CMake
From: "Raphael Kubo da Costa" <rakuco () FreeBSD ! org>
Date: 2015-06-15 12:19:07
Message-ID: 20150615121907.15191.89563 () mimi ! kde ! org
[Download RAW message or body]
--===============2265408532014339377==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123968/#review81479
-----------------------------------------------------------
In addition to the items below, I suggest you try building Labplot with CMake 2.8.10 \
to check if it works fine with the `FindGSL.cmake` you've imported since that version \
was added to CMake after 2.8.10 and thus may use some features that are not present \
in that version. Building CMake is easy, just make sure you use the binary you've \
built instead of your system one when calling it to build Labplot.
CMakeLists.txt (line 4)
<https://git.reviewboard.kde.org/r/123968/#comment55832>
This will fail if you're using an older CMake, as you haven't added `cmake/` to \
`$CMAKE_MODULE_PATH` yet. And to prevent your version from always being used even if \
CMake ships its own `FindGSL.cmake` you could check `CMAKE_VERSION` and conditionally \
change `CMAKE_MODULE_PATH` before or after looking for `GSL`.
cmake/FindGSL.cmake (line 48)
<https://git.reviewboard.kde.org/r/123968/#comment55833>
Note that the variable is now called `GSL_CBLAS_LIBRARY` and not \
`GSL_CBLAS_LIBRARIES`, so you need to adjust `src/CMakeLists.txt` (or use the \
imported target above).
- Raphael Kubo da Costa
On June 14, 2015, 9:42 a.m., David Narváez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123968/
> -----------------------------------------------------------
>
> (Updated June 14, 2015, 9:42 a.m.)
>
>
> Review request for KDE Edu and Marko Käning.
>
>
> Repository: labplot
>
>
> Description
> -------
>
> Use the module provided by CMake. Setting compile definitions HAVE_GSL and \
> GSL_VERSION has no effect in the code so I removed them.
>
> Diffs
> -----
>
> CMakeLists.txt 980909c5b7b3effe70f0478f5e2128870f342e8f
> cmake/FindGSL.cmake PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/123968/diff/
>
>
> Testing
> -------
>
> Compiled with make VERBOSE=1 to see the compile commands. I am not sure if this \
> still works in the OSX configuration, Marko?
>
> Thanks,
>
> David Narváez
>
>
--===============2265408532014339377==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123968/">https://git.reviewboard.kde.org/r/123968/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In \
addition to the items below, I suggest you try building Labplot with CMake 2.8.10 to \
check if it works fine with the <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">FindGSL.cmake</code> you've imported since that version was added to CMake \
after 2.8.10 and thus may use some features that are not present in that version. \
Building CMake is easy, just make sure you use the binary you've built instead of \
your system one when calling it to build Labplot.</p></pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/123968/diff/3/?file=379850#file379850line4" \
style="color: black; font-weight: bold; text-decoration: \
underline;">CMakeLists.txt</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">4</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">find_package</span><span class="p">(</span><span class="s">GSL</span> \
<span class="s">REQUIRED</span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
will fail if you're using an older CMake, as you haven't added <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">cmake/</code> to <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">$CMAKE_MODULE_PATH</code> yet. And to prevent your version from always \
being used even if CMake ships its own <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">FindGSL.cmake</code> you could check <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">CMAKE_VERSION</code> and conditionally change <code style="text- \
rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">CMAKE_MODULE_PATH</code> before or after looking for <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">GSL</code>.</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/123968/diff/3/?file=379851#file379851line48" \
style="color: black; font-weight: bold; text-decoration: \
underline;">cmake/FindGSL.cmake</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">48</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="c"># GSL_CLBAS_LIBRARY - Location of the GSL CBLAS \
library.</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Note \
that the variable is now called <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">GSL_CBLAS_LIBRARY</code> and not <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">GSL_CBLAS_LIBRARIES</code>, so you need to adjust <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">src/CMakeLists.txt</code> (or use the imported target \
above).</p></pre> </div>
</div>
<br />
<p>- Raphael Kubo da Costa</p>
<br />
<p>On June 14th, 2015, 9:42 a.m. EEST, David Narváez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu and Marko Käning.</div>
<div>By David Narváez.</div>
<p style="color: grey;"><i>Updated June 14, 2015, 9:42 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
labplot
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Use the module provided by CMake. Setting compile \
definitions HAVE_GSL and GSL_VERSION has no effect in the code so I removed \
them.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Compiled with make VERBOSE=1 to see the compile \
commands. I am not sure if this still works in the OSX configuration, \
Marko?</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(980909c5b7b3effe70f0478f5e2128870f342e8f)</span></li>
<li>cmake/FindGSL.cmake <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123968/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2265408532014339377==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic