'Review Request 122889: Explicitly look for KArchive'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu
Subject:    Review Request 122889: Explicitly look for KArchive
From:       "Harald Sitter" <sitter () kde ! org>
Date:       2015-03-10 12:07:57
Message-ID: 20150310120757.23878.73594 () mimi ! kde ! org
[Download RAW message or body]

--===============8507232013967648665==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122889/
-----------------------------------------------------------

Review request for KDE Edu and Andreas Cord-Landwehr.

Repository: rocs

Description
-------

KF5::Archive is used as a target, but not explicitly dragged in. Whichever
framework previously dragged it in as depedendency does not do so anymore in
git master, so take the safe route and make explicitly sure that KArchive is present.

Diffs
-----

  CMakeLists.txt 0ee8a2258fb09fc1ea663e6cf94f643eabde382d 

Diff: https://git.reviewboard.kde.org/r/122889/diff/

Testing
-------

make && make -j && sudo make install && ctest; echo $?
0

Thanks,

Harald Sitter

--===============8507232013967648665==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122889/">https://git.reviewboard.kde.org/r/122889/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Edu and Andreas Cord-Landwehr.</div>
<div>By Harald Sitter.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
rocs
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">KF5::Archive is used as a target, but not explicitly dragged in. \
Whichever framework previously dragged it in as depedendency does not do so anymore \
in git master, so take the safe route and make explicitly sure that KArchive is \
present.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">make &amp;&amp; make -j &amp;&amp; sudo make install \
&amp;&amp; ctest; echo $? 0</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: \
grey">(0ee8a2258fb09fc1ea663e6cf94f643eabde382d)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122889/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8507232013967648665==--

[Attachment #3 (text/plain)]

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 