[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu
Subject: Re: Review Request 122771: method to ignore extra white spaces.
From: "Inge Wallin" <inge () lysator ! liu ! se>
Date: 2015-03-08 18:02:36
Message-ID: 20150308180236.4264.24414 () probe ! kde ! org
[Download RAW message or body]
--===============8119609692915521898==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122771/#review77187
-----------------------------------------------------------
src/practice/writtenpracticevalidator.h
<https://git.reviewboard.kde.org/r/122771/#comment53021>
As I think we agreed about on irc, the purpose is not to remove all whitespaces, \
only unnecessary ones. So perhaps we should try to find another name for this \
function.
src/practice/writtenpracticevalidator.cpp
<https://git.reviewboard.kde.org/r/122771/#comment53022>
You don't have to create a new string. You can just use 'letter' in the \
foreach(). Also, 'letter' is a bad name because it's not just one letter, it can \
contain one or even several sentences. So 'word' is also a bad name.
src/practice/writtenpracticevalidator.cpp
<https://git.reviewboard.kde.org/r/122771/#comment53023>
I'm not 100% sure but I think removing a character from a string that you are \
looping through using foreach() is dangerous. I would suggest to let the original \
string be as it is, and instead build a new one from the characters that you select.
Some more comments
- Inge Wallin
On March 2, 2015, 11:53 a.m., ankit wagadre wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122771/
> -----------------------------------------------------------
>
> (Updated March 2, 2015, 11:53 a.m.)
>
>
> Review request for KDE Edu and Inge Wallin.
>
>
> Repository: parley
>
>
> Description
> -------
>
> Method to ignore extra white spaces.And some corrections.
>
>
> Diffs
> -----
>
> src/practice/writtenbackendmode.cpp 23b0260
> src/practice/writtenpracticevalidator.h ee99b25
> src/practice/writtenpracticevalidator.cpp 714ce01
>
> Diff: https://git.reviewboard.kde.org/r/122771/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> ankit wagadre
>
>
--===============8119609692915521898==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122771/">https://git.reviewboard.kde.org/r/122771/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/122771/diff/1/?file=352711#file352711line45" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/practice/writtenpracticevalidator.h</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">45</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QString</span> <span class="nf">removeWhitespaces</span><span \
class="p">(</span><span class="k">const</span> <span class="n">QString</span><span \
class="o">&</span> <span class="n">letter</span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As I \
think we agreed about on irc, the purpose is not to remove all whitespaces, only \
unnecessary ones. So perhaps we should try to find another name for this \
function.</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/122771/diff/1/?file=352712#file352712line138" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/practice/writtenpracticevalidator.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">138</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QString</span> <span class="n">word</span> <span class="o">=</span> <span \
class="n">letter</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You \
don't have to create a new string. You can just use 'letter' in the foreach(). Also, \
'letter' is a bad name because it's not just one letter, it can contain one or even \
several sentences. So 'word' is also a bad name.</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/122771/diff/1/?file=352712#file352712line142" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/practice/writtenpracticevalidator.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">142</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">word</span><span class="p">.</span><span class="n">remove</span><span \
class="p">(</span><span class="n">pos</span><span class="p">,</span><span \
class="mi">1</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm \
not 100% sure but I think removing a character from a string that you are looping \
through using foreach() is dangerous. I would suggest to let the original string be \
as it is, and instead build a new one from the characters that you select.</p></pre> \
</div> </div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Some \
more comments</p></pre>
<p>- Inge Wallin</p>
<br />
<p>On March 2nd, 2015, 11:53 a.m. CET, ankit wagadre wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu and Inge Wallin.</div>
<div>By ankit wagadre.</div>
<p style="color: grey;"><i>Updated March 2, 2015, 11:53 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Method to ignore extra white spaces.And some \
corrections.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/practice/writtenbackendmode.cpp <span style="color: \
grey">(23b0260)</span></li>
<li>src/practice/writtenpracticevalidator.h <span style="color: \
grey">(ee99b25)</span></li>
<li>src/practice/writtenpracticevalidator.cpp <span style="color: \
grey">(714ce01)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122771/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8119609692915521898==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic