'Re: Review Request 122674: New option to ignore punctuations'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu
Subject:    Re: Review Request 122674: New option to ignore punctuations
From:       "Inge Wallin" <inge () lysator ! liu ! se>
Date:       2015-02-22 14:00:20
Message-ID: 20150222140020.28677.72294 () probe ! kde ! org
[Download RAW message or body]

--===============5365163059208051700==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122674/#review76426
-----------------------------------------------------------

Ship it!

This is ok now. Good work!

- Inge Wallin

On Feb. 22, 2015, 2:52 p.m., ankit wagadre wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122674/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2015, 2:52 p.m.)
> 
> 
> Review request for KDE Edu and Inge Wallin.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> option to ignore punctuations.check this one i'll delete old one.
> 
> 
> Diffs
> -----
> 
> src/practice/writtenpracticevalidator.cpp e974441 
> src/practice/configure/generalpracticeoptions.ui a40c739 
> src/settings/parley.kcfg 0037420 
> src/practice/writtenpracticevalidator.h 93e7423 
> src/practice/writtenbackendmode.cpp 7b221b7 
> src/collection/testentry.h 4f47c38 
> 
> Diff: https://git.reviewboard.kde.org/r/122674/diff/
> 
> 
> Testing
> -------
> 
> i have done testing it works fine.and about ur comment that y should capitaliztion \
> check for punctuation,if u ingnore capitalization is checked then the string should \
> be checked for puntuation mistake for lower alphabets. 
> 
> Thanks,
> 
> ankit wagadre
> 
> 

--===============5365163059208051700==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122674/">https://git.reviewboard.kde.org/r/122674/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
is ok now. Good work!</p></pre>  <br />

<p>- Inge Wallin</p>

<br />
<p>On February 22nd, 2015, 2:52 p.m. CET, ankit wagadre wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Edu and Inge Wallin.</div>
<div>By ankit wagadre.</div>

<p style="color: grey;"><i>Updated Feb. 22, 2015, 2:52 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">option to ignore punctuations.check this one i'll \
delete old one.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">i have done testing it works fine.and about ur comment \
that y should capitaliztion check for punctuation,if u ingnore capitalization is \
checked then the string should be checked for puntuation mistake for lower \
alphabets.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/practice/writtenpracticevalidator.cpp <span style="color: \
grey">(e974441)</span></li>

 <li>src/practice/configure/generalpracticeoptions.ui <span style="color: \
grey">(a40c739)</span></li>

 <li>src/settings/parley.kcfg <span style="color: grey">(0037420)</span></li>

 <li>src/practice/writtenpracticevalidator.h <span style="color: \
grey">(93e7423)</span></li>

 <li>src/practice/writtenbackendmode.cpp <span style="color: \
grey">(7b221b7)</span></li>

 <li>src/collection/testentry.h <span style="color: grey">(4f47c38)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122674/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5365163059208051700==--

[Attachment #3 (text/plain)]

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 