[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 122568: option to ignore punctuation
From: "Inge Wallin" <inge () lysator ! liu ! se>
Date: 2015-02-21 19:06:01
Message-ID: 20150221190601.4988.4584 () probe ! kde ! org
[Download RAW message or body]
--===============6697584090064084204==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Feb. 15, 2015, 5:52 a.m., Inge Wallin wrote:
> > Hi Ankit,
> > I can't check the current state of the patch since you ony added the changes from \
> > version 1. What I saw looked good, but I can't give you a Ship it just yet. But \
> > you are close.
> > Today I will go on a trip to Poland so I suggest that you ask jpwhiting to help \
> > you with the review. He can show you what to do and knows enough to give you the \
> > Ok.
>
> Inge Wallin wrote:
> Hello, what happened? It would be very good if you could post the complete patch \
> since the feature freeze for the next version is on wednesday and I would like to \
> get this in before then. I think you did a good job, I just want to take a look at \
> the complete work once before ok 'ing it.
I forgot to write that if you are having trouble with handling the review board, \
either come to IRC and I will help you there or you can send the patch to me in a \
mail.
- Inge
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122568/#review76039
-----------------------------------------------------------
On Feb. 15, 2015, 5:11 a.m., ankit wagadre wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122568/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2015, 5:11 a.m.)
>
>
> Review request for KDE Edu and Inge Wallin.
>
>
> Repository: parley
>
>
> Description
> -------
>
> An option to ignore punctuation has been added.
>
>
> Diffs
> -----
>
> 0001-option-to-ignore-punctation-has-been-added.patch PRE-CREATION
> src/collection/testentry.h 4f47c38
> src/practice/writtenpracticevalidator.cpp e974441
>
> Diff: https://git.reviewboard.kde.org/r/122568/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> ankit wagadre
>
>
--===============6697584090064084204==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122568/">https://git.reviewboard.kde.org/r/122568/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 15th, 2015, 5:52 a.m. CET, <b>Inge \
Wallin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Hi Ankit, I can't check the current state of the patch \
since you ony added the changes from version 1. What I saw looked good, but I can't \
give you a Ship it just yet. But you are close.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Today \
I will go on a trip to Poland so I suggest that you ask jpwhiting to help you with \
the review. He can show you what to do and knows enough to give you the \
Ok.</p></pre> </blockquote>
<p>On February 21st, 2015, 8:05 p.m. CET, <b>Inge Wallin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Hello, what happened? It would be very good if you could post the complete \
patch since the feature freeze for the next version is on wednesday and I would like \
to get this in before then. I think you did a good job, I just want to take a look \
at the complete work once before ok 'ing it.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
forgot to write that if you are having trouble with handling the review board, either \
come to IRC and I will help you there or you can send the patch to me in a \
mail.</p></pre> <br />
<p>- Inge</p>
<br />
<p>On February 15th, 2015, 5:11 a.m. CET, ankit wagadre wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu and Inge Wallin.</div>
<div>By ankit wagadre.</div>
<p style="color: grey;"><i>Updated Feb. 15, 2015, 5:11 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
parley
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">An option to ignore punctuation has been \
added.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>0001-option-to-ignore-punctation-has-been-added.patch <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/collection/testentry.h <span style="color: grey">(4f47c38)</span></li>
<li>src/practice/writtenpracticevalidator.cpp <span style="color: \
grey">(e974441)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122568/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6697584090064084204==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic