'Re: Review Request 122497: Start a New Kig Application for the New Action'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu
Subject:    Re: Review Request 122497: Start a New Kig Application for the New Action
From:       David_Narváez <david.narvaez () computer ! org>
Date:       2015-02-09 13:31:51
Message-ID: 20150209133151.30354.11644 () probe ! kde ! org
[Download RAW message or body]

--===============4005879656602300278==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122497/
-----------------------------------------------------------

(Updated Feb. 9, 2015, 1:31 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Edu.

Repository: kig

Description
-------

The previous behavior made sense when Kig was a KUniqueApplication, but now that it \
is not, running a new application is the best way to go. Another option would be to \
turn the Kig interface into an MDI, but that requires a lot more work. Notice that \
the binary found to run Kig might not be the same as the running binary.

Diffs
-----

  kig/kig.cpp 3b3a2de 

Diff: https://git.reviewboard.kde.org/r/122497/diff/

Testing
-------

1. Start kig
2. Draw something
3. Click the New button
4. Check the number of Kig processes (Ctrl + Esc or $ ps aux | grep kig in the \
console)

Before this patch, a new window would open, but only one kig process would be \
running. After this patch, a new Kig process starts.

Thanks,

David Narváez

--===============4005879656602300278==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122497/">https://git.reviewboard.kde.org/r/122497/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Edu.</div>
<div>By David Narváez.</div>

<p style="color: grey;"><i>Updated Feb. 9, 2015, 1:31 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kig
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The previous behavior made sense when Kig was a \
KUniqueApplication, but now that it is not, running a new application is the best way \
to go. Another option would be to turn the Kig interface into an MDI, but that \
requires a lot more work. Notice that the binary found to run Kig might not be the \
same as the running binary.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
2em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Start kig</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Draw something</li> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">Click the New button</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Check the number of Kig processes (Ctrl + Esc or $ ps aux | grep kig in the \
console)</li> </ol>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Before this patch, a new window would open, but only \
one kig process would be running. After this patch, a new Kig process \
starts.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kig/kig.cpp <span style="color: grey">(3b3a2de)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122497/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4005879656602300278==--

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 