'Re: Review Request 118310: support for graphic properties of Geogebra objects in KIG'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu
Subject:    Re: Review Request 118310: support for graphic properties of Geogebra objects in KIG
From:       David_Narváez <david.narvaez () computer ! org>
Date:       2015-01-08 3:03:01
Message-ID: 20150108030301.15695.6010 () probe ! kde ! org
[Download RAW message or body]

--===============3508200989482451360==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118310/#review73436
-----------------------------------------------------------

Ship it!

Where's the code that was put into another patch?

- David Narváez

On Dec. 24, 2014, 12:50 p.m., Aniket Anvit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118310/
> -----------------------------------------------------------
> 
> (Updated Dec. 24, 2014, 12:50 p.m.)
> 
> 
> Review request for KDE Edu and David Narváez.
> 
> 
> Repository: kig
> 
> 
> Description
> -------
> 
> This patch enables KIG to read the graphic properties of Geogebra objects from \
> Geogebra worksheets. Here is some explanation about my implementation:
> 
> the graphic properties ( lineStyle, pointStyle, lineWidth, color ) are read for \
> each geogebra object. I add an attribute for each property to each of the \
> intermediate representation of each of the objects created using XSLT. Some \
> variables are added to the KigFilterGeogebra class to hold the values of the \
> properties for each of the objects. In the attribute() callback method of the \
> KigFilterGeogebra class , the values of the properties are read ( and suitably \
> mapped to KIG's ) and when the endElement() callback is called a new ObjectDrawer \
> with the last read properties is allocated for this object. 
> 
> Diffs
> -----
> 
> geogebra/geogebrasection.cpp e9778ed 
> geogebra/geogebratransformer.h 5f36827 
> geogebra/geogebratransformer.cpp aee8669 
> filters/geogebra-filter.cpp cff342d 
> geogebra/geogebra.xsl c1e4749 
> geogebra/geogebrasection.h aed7dcb 
> 
> Diff: https://git.reviewboard.kde.org/r/118310/diff/
> 
> 
> Testing
> -------
> 
> Tested! some trouble in the mapping of PointStyles.
> 
> 
> File Attachments
> ----------------
> 
> Test file
> https://git.reviewboard.kde.org/media/uploaded/files/2014/11/15/9799362b-472e-4814-9d78-da2bf07d612c__gui.ggb
>  
> 
> Thanks,
> 
> Aniket Anvit
> 
> 

--===============3508200989482451360==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118310/">https://git.reviewboard.kde.org/r/118310/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Where's the code that was put into another patch?</p></pre>  <br />

<p>- David Narváez</p>

<br />
<p>On December 24th, 2014, 12:50 p.m. UTC, Aniket Anvit wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Edu and David Narváez.</div>
<div>By Aniket Anvit.</div>

<p style="color: grey;"><i>Updated Dec. 24, 2014, 12:50 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kig
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch enables KIG to read the graphic properties \
of Geogebra objects from Geogebra worksheets. Here is some explanation about my \
implementation:</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">the graphic properties ( lineStyle, \
pointStyle, lineWidth, color ) are read for each geogebra object. I add an attribute \
for each property to each of the intermediate representation of each of the objects \
created using XSLT. Some variables are added to the KigFilterGeogebra class to hold \
the values of the properties for each of the objects. In the attribute() callback \
method of the KigFilterGeogebra class , the values of the properties are read ( and \
suitably mapped to KIG's ) and when the endElement() callback is called a new \
ObjectDrawer with the last read properties is allocated for this object.</p></pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested! some trouble in the mapping of \
PointStyles.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>geogebra/geogebrasection.cpp <span style="color: grey">(e9778ed)</span></li>

 <li>geogebra/geogebratransformer.h <span style="color: grey">(5f36827)</span></li>

 <li>geogebra/geogebratransformer.cpp <span style="color: grey">(aee8669)</span></li>

 <li>filters/geogebra-filter.cpp <span style="color: grey">(cff342d)</span></li>

 <li>geogebra/geogebra.xsl <span style="color: grey">(c1e4749)</span></li>

 <li>geogebra/geogebrasection.h <span style="color: grey">(aed7dcb)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118310/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/11/15/9799362b-472e-4814-9d78-da2bf07d612c__gui.ggb">Test \
file</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3508200989482451360==--

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 