[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu
Subject: Re: Review Request 118785: Segment Axis object in KIG ( GSoC 14 )
From: David_Narváez <david.narvaez () computer ! org>
Date: 2014-06-24 16:51:13
Message-ID: 20140624165113.24601.1751 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On June 18, 2014, 11:35 a.m., Maurizio Paolini wrote:
> > The old segment_axis macro required as argument a segment, whereas the new \
> > construction depends on two points... this could lead to some confusion, and \
> > actually, the name SegmentAxisABType is a little bit incorrect.
> > A user that is accustomed to the old segment_axis would find the use of the new
> > SegmentAxisABType different.
> > Question: what is the reason to add this new construction?
>
> Aniket Anvit wrote:
> The macro one could only construct the perpendicular bisector for segments. Since \
> the object one takes two points as inputs, it can construct the \
> perpendicular-bisector of any two points ( even if there is no segment constructed \
> with them ). Also, perpendicular-bisector is an important constructionso we should \
> have it directly implemented as an object rather than as a built-in macro. It will \
> be better...
> Maurizio Paolini wrote:
> I am aware of that, however changing the parents *will* change how the user \
> interacts with kig. Moreover, there are situations (in particular when \
> constructing a new macro) where it is important for the user to understand exactly \
> what is the hierarchy of the constructed object, although in this particular case \
> letting the axis depend on the two points is probably better.
> Please, let me clarify that I am *not* contrary to the new Object construction!
>
> Anyway, let me make a proposal: the creation of a "special constructor" should \
> allow the user to construct the "perpendicular bisector" in both ways:
>
> - either by clicking on the two points (then the new object is directly used)
> - or by clicking on the segment, in which case "kig" should construct the two \
> end-points and then use the new object
> I guess that the present implementation of "mid-point" is exactly of this sort!
I only read these comments today, sorry about that. Maurizio is right about not \
changing the behavior, and the last suggestion about making it like mid point is what \
we need. I'll work on that fix now.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118785/#review60377
-----------------------------------------------------------
On June 19, 2014, 5:43 a.m., Aniket Anvit wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118785/
> -----------------------------------------------------------
>
> (Updated June 19, 2014, 5:43 a.m.)
>
>
> Review request for KDE Edu and David Narváez.
>
>
> Repository: kig
>
>
> Description
> -------
>
> This patch adds the segment axis object to KIG. This new object will take two \
> points as input and generates a line which would perpendicularly bisect the segment \
> constructed with those two points.
>
> Diffs
> -----
>
> macros/CMakeLists.txt 8abf249
> macros/segment_axis.kigt e86b90c
> misc/builtin_stuff.cc 28846c8
> objects/line_type.h 3ea252b
> objects/line_type.cc dbf575c
>
> Diff: https://git.reviewboard.kde.org/r/118785/diff/
>
>
> Testing
> -------
>
> Took 6 points and constructed the perpendicular-bisectors choosing random pair. \
> Tested with semgents too.
>
> Thanks,
>
> Aniket Anvit
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118785/">https://git.reviewboard.kde.org/r/118785/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 18th, 2014, 11:35 a.m. UTC, <b>Maurizio \
Paolini</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The old segment_axis macro required as argument a segment, whereas the \
new construction depends on two points... this could lead to some confusion, and \
actually, the name SegmentAxisABType is a little bit incorrect.
A user that is accustomed to the old segment_axis would find the use of the new
SegmentAxisABType different.
Question: what is the reason to add this new construction?</pre>
</blockquote>
<p>On June 19th, 2014, 5:07 a.m. UTC, <b>Aniket Anvit</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The macro one could only \
construct the perpendicular bisector for segments. Since the object one takes two \
points as inputs, it can construct the perpendicular-bisector of any two points ( \
even if there is no segment constructed with them ). Also, perpendicular-bisector is \
an important constructionso we should have it directly implemented as an object \
rather than as a built-in macro. It will be better...</pre> </blockquote>
<p>On June 19th, 2014, 9:53 a.m. UTC, <b>Maurizio Paolini</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am aware of that, \
however changing the parents *will* change how the user interacts with kig. \
Moreover, there are situations (in particular when constructing a new macro) where it \
is important for the user to understand exactly what is the hierarchy of the \
constructed object, although in this particular case letting the axis depend on the \
two points is probably better.
Please, let me clarify that I am *not* contrary to the new Object construction!
Anyway, let me make a proposal: the creation of a "special constructor" \
should allow the user to construct the "perpendicular bisector" in both \
ways:
- either by clicking on the two points (then the new object is directly used)
- or by clicking on the segment, in which case "kig" should construct the \
two end-points and then use the new object
I guess that the present implementation of "mid-point" is exactly of this \
sort!</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I only read these \
comments today, sorry about that. Maurizio is right about not changing the behavior, \
and the last suggestion about making it like mid point is what we need. I'll work \
on that fix now.</pre> <br />
<p>- David</p>
<br />
<p>On June 19th, 2014, 5:43 a.m. UTC, Aniket Anvit wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu and David Narváez.</div>
<div>By Aniket Anvit.</div>
<p style="color: grey;"><i>Updated June 19, 2014, 5:43 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kig
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds the segment axis object to KIG. This new object will \
take two points as input and generates a line which would perpendicularly bisect the \
segment constructed with those two points.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Took 6 points and constructed the perpendicular-bisectors choosing \
random pair. Tested with semgents too.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>macros/CMakeLists.txt <span style="color: grey">(8abf249)</span></li>
<li>macros/segment_axis.kigt <span style="color: grey">(e86b90c)</span></li>
<li>misc/builtin_stuff.cc <span style="color: grey">(28846c8)</span></li>
<li>objects/line_type.h <span style="color: grey">(3ea252b)</span></li>
<li>objects/line_type.cc <span style="color: grey">(dbf575c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118785/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic