'Re: Review Request 115758: Add sound to kgeography'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu
Subject:    Re: Review Request 115758: Add sound to kgeography
From:       "Albert Astals Cid" <aacid () kde ! org>
Date:       2014-02-16 22:43:32
Message-ID: 20140216224332.25204.19269 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115758/#review49998
-----------------------------------------------------------

src/CMakeLists.txt
<https://git.reviewboard.kde.org/r/115758/#comment35102>

    Why do we need kio?

src/askwidget.h
<https://git.reviewboard.kde.org/r/115758/#comment35103>

    no need for kurl here?

src/kgeography.h
<https://git.reviewboard.kde.org/r/115758/#comment35105>

    why do we need this?

src/kgeography.h
<https://git.reviewboard.kde.org/r/115758/#comment35106>

    Why do we need to have the configure dialog created all the time now?

src/kgeography.kcfg
<https://git.reviewboard.kde.org/r/115758/#comment35104>

    Maybe make this an Url so you don't need the casts in the askWidget::playSound function?

- Albert Astals Cid

On Feb. 16, 2014, 10:30 a.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115758/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2014, 10:30 a.m.)
> 
> 
> Review request for KDE Edu and Albert Astals Cid.
> 
> 
> Bugs: 132702
>     http://bugs.kde.org/show_bug.cgi?id=132702
> 
> 
> Repository: kgeography
> 
> 
> Description
> -------
> 
> The code to choose the sound file is borrowed from kalarm.
> Add phonon to play sounds (can not be easier).
> Add the configuration to select the sound files.
> 
> 
> Diffs
> -----
> 
>   src/divisionflagasker.h ffee8c2 
>   src/divisionflagasker.cpp 361c973 
>   src/flagdivisionasker.h 623a249 
>   src/flagdivisionasker.cpp 34f7711 
>   src/kgeography.h 4506bd0 
>   src/kgeography.cpp e5e5305 
>   src/kgeography.kcfg 14f5d4f 
>   src/kgeographyoptions.ui 109b077 
>   src/mapasker.h 4e89fe5 
>   src/mapasker.cpp 22e0c24 
>   src/placeasker.h 7d27178 
>   src/placeasker.cpp d65e030 
>   CMakeLists.txt e7a6d9c 
>   src/CMakeLists.txt 9e49f0d 
>   src/askwidget.h 32421b0 
>   src/askwidget.cpp 7f9e3cc 
>   src/boxasker.h 507099f 
>   src/boxasker.cpp f0a5b60 
>   src/capitaldivisionasker.h 744c43c 
>   src/capitaldivisionasker.cpp 495eb26 
>   src/divisioncapitalasker.h 0246482 
>   src/divisioncapitalasker.cpp 625379b 
> 
> Diff: https://git.reviewboard.kde.org/r/115758/diff/
> 
> 
> Testing
> -------
> 
> It only make sounds when selected in the configuration, and the sound file exists.
> 
> 
> Thanks,
> 
> Jaime Torres Amate
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115758/">https://git.reviewboard.kde.org/r/115758/</a>
  </td>
    </tr>
   </table>
   <br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/115758/diff/3/?file=244338#file244338line41" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/CMakeLists.txt</a>  <span style="font-weight: normal;">

     (Diff revision 3)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">41</font></th>  <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">target_link_libraries</span><span class="p">(</span><span \
class="s">kgeography</span>   <span class="o">${</span><span \
class="nv">KDE4_KDEUI_LIBS</span><span class="o">}</span> <span \
class="o">${</span><span class="nv">QT_QTXML_LIBRARY</span><span \
class="o">}</span><span class="p">)</span></pre></td>  <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">41</font></th>  <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">target_link_libraries</span><span class="p">(</span><span \
class="s">kgeography</span>   <span class="o">${</span><span \
class="nv">KDE4_KDEUI_LIBS</span><span class="o">}</span> <span \
class="o">${</span><span class="nv"><span class="hl">KDE4_KIO_LIBS</span></span><span \
class="o"><span class="hl">}</span></span><span class="hl"> </span><span \
class="o"><span class="hl">${</span></span><span class="nv"><span \
class="hl">KDE4_PHONON_LIBS</span></span><span class="o"><span \
class="hl">}</span></span><span class="hl"> </span><span class="o"><span \
class="hl">${</span></span><span class="nv">QT_QTXML_LIBRARY</span><span \
class="o">}</span><span class="p">)</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why do we \
need kio?</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/115758/diff/3/?file=244339#file244339line22" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/askwidget.h</a>  <span style="font-weight: normal;">

     (Diff revision 3)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">22</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cp">#include &lt;kurl.h&gt;</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">no need for \
kurl here?</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/115758/diff/3/?file=244351#file244351line15" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/kgeography.h</a>  <span style="font-weight: normal;">

     (Diff revision 3)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">15</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cp">#include &lt;kfile.h&gt;</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">why do we \
need this?</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/115758/diff/3/?file=244351#file244351line97" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/kgeography.h</a>  <span style="font-weight: normal;">

     (Diff revision 3)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">Q_OBJECT</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">97</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb">	</span><span class="tb">	</span><span class="n">Ui</span><span \
class="o">::</span><span class="n">Options</span> <span class="n">confWdg</span><span \
class="p">;</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why do we \
need to have the configure dialog created all the time now?</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="https://git.reviewboard.kde.org/r/115758/diff/3/?file=244353#file244353line46" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/kgeography.kcfg</a>  <span style="font-weight: normal;">

     (Diff revision 3)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">46</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb">	</span><span class="tb">	</span>&lt;entry \
name=&quot;soundFileCorrectAnswer&quot; type=&quot;String&quot;&gt;</pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Maybe make \
this an Url so you don&#39;t need the casts in the askWidget::playSound \
function?</pre> </div>
<br />

<p>- Albert Astals Cid</p>

<br />
<p>On February 16th, 2014, 10:30 a.m. UTC, Jaime Torres Amate wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Edu and Albert Astals Cid.</div>
<div>By Jaime Torres Amate.</div>

<p style="color: grey;"><i>Updated Feb. 16, 2014, 10:30 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=132702">132702</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kgeography
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The code to choose the sound file is borrowed from kalarm. Add phonon to \
play sounds (can not be easier). Add the configuration to select the sound \
files.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It only make sounds when selected in the configuration, and the sound \
file exists.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/divisionflagasker.h <span style="color: grey">(ffee8c2)</span></li>

 <li>src/divisionflagasker.cpp <span style="color: grey">(361c973)</span></li>

 <li>src/flagdivisionasker.h <span style="color: grey">(623a249)</span></li>

 <li>src/flagdivisionasker.cpp <span style="color: grey">(34f7711)</span></li>

 <li>src/kgeography.h <span style="color: grey">(4506bd0)</span></li>

 <li>src/kgeography.cpp <span style="color: grey">(e5e5305)</span></li>

 <li>src/kgeography.kcfg <span style="color: grey">(14f5d4f)</span></li>

 <li>src/kgeographyoptions.ui <span style="color: grey">(109b077)</span></li>

 <li>src/mapasker.h <span style="color: grey">(4e89fe5)</span></li>

 <li>src/mapasker.cpp <span style="color: grey">(22e0c24)</span></li>

 <li>src/placeasker.h <span style="color: grey">(7d27178)</span></li>

 <li>src/placeasker.cpp <span style="color: grey">(d65e030)</span></li>

 <li>CMakeLists.txt <span style="color: grey">(e7a6d9c)</span></li>

 <li>src/CMakeLists.txt <span style="color: grey">(9e49f0d)</span></li>

 <li>src/askwidget.h <span style="color: grey">(32421b0)</span></li>

 <li>src/askwidget.cpp <span style="color: grey">(7f9e3cc)</span></li>

 <li>src/boxasker.h <span style="color: grey">(507099f)</span></li>

 <li>src/boxasker.cpp <span style="color: grey">(f0a5b60)</span></li>

 <li>src/capitaldivisionasker.h <span style="color: grey">(744c43c)</span></li>

 <li>src/capitaldivisionasker.cpp <span style="color: grey">(495eb26)</span></li>

 <li>src/divisioncapitalasker.h <span style="color: grey">(0246482)</span></li>

 <li>src/divisioncapitalasker.cpp <span style="color: grey">(625379b)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115758/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 