[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu
Subject: Re: Review Request 115439: Open ExpressionWritter API: AbstractExpressionWriter
From: Percy_Camilo_Triveño_Aucahuasi <percy.camilo.ta () gmail ! com>
Date: 2014-02-15 17:04:04
Message-ID: 20140215170404.11774.43947 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115439/
-----------------------------------------------------------
(Updated Feb. 15, 2014, 5:04 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Edu.
Repository: analitza
Description
-------
Currently ExpressionWriter allows a great flexibility to visit each node (by type) of \
the parser's tree, but it returns only QString as result.
I propose open this API by this generic interface: AbstractExpressionWriter. This \
interface can be used by any client to visit the tree and, in addition, the client \
can choose the type of the results for each visit.
This patch adds AbstractExpressionWriter, ExpressionWriter, List, CustomObject, \
Matrix, Apply and Container as public API (headers will be installed)
Diffs
-----
analitza/CMakeLists.txt af270b6
analitza/abstractexpressionvisitor.h PRE-CREATION
analitza/abstractexpressionvisitor.cpp PRE-CREATION
analitza/analitzautils.cpp c38eeaa
analitza/apply.h 84b09f5
analitza/apply.cpp e787372
analitza/container.h f0deec6
analitza/container.cpp aabd780
analitza/customobject.h b6f200c
analitza/customobject.cpp da8bdb9
analitza/expression.cpp 48fd8d8
analitza/expressiontypechecker.h 8263c2b
analitza/expressiontypechecker.cpp 8616127
analitza/expressionwriter.h ea9c92d
analitza/expressionwriter.cpp 8aff488
analitza/htmlexpressionwriter.h f8d0060
analitza/htmlexpressionwriter.cpp cf7d4a0
analitza/list.h 9719f9e
analitza/list.cpp fd1e411
analitza/mathmlexpressionwriter.h 70b08ae
analitza/mathmlexpressionwriter.cpp b70a1ca
analitza/mathmlpresentationexpressionwriter.h 6c6419e
analitza/mathmlpresentationexpressionwriter.cpp 3efc35b
analitza/matrix.h 69c109d
analitza/matrix.cpp 6714ac8
analitza/object.h aafd114
analitza/object.cpp b485d07
analitza/operator.h 0e61b21
analitza/operator.cpp a2d8501
analitza/stringexpressionwriter.h e8c0ccd
analitza/stringexpressionwriter.cpp 90594e8
analitza/value.h 89bc2ef
analitza/value.cpp 7d4e49a
analitza/variable.h 2f8514c
analitza/variable.cpp b98365e
analitza/vector.h 338bf81
analitza/vector.cpp d7b5836
Diff: https://git.reviewboard.kde.org/r/115439/diff/
Testing
-------
build & install ok, also each class has the ANALITZA_EXPORT macro.
Thanks,
Percy Camilo Triveño Aucahuasi
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115439/">https://git.reviewboard.kde.org/r/115439/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By Percy Camilo Triveño Aucahuasi.</div>
<p style="color: grey;"><i>Updated Feb. 15, 2014, 5:04 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
analitza
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently ExpressionWriter allows a great flexibility to visit each node \
(by type) of the parser's tree, but it returns only QString as result.
I propose open this API by this generic interface: AbstractExpressionWriter. This \
interface can be used by any client to visit the tree and, in addition, the client \
can choose the type of the results for each visit.
This patch adds AbstractExpressionWriter, ExpressionWriter, List, CustomObject, \
Matrix, Apply and Container as public API (headers will be installed) </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">build & install ok, also each class has the ANALITZA_EXPORT \
macro.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>analitza/CMakeLists.txt <span style="color: grey">(af270b6)</span></li>
<li>analitza/abstractexpressionvisitor.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>analitza/abstractexpressionvisitor.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>analitza/analitzautils.cpp <span style="color: grey">(c38eeaa)</span></li>
<li>analitza/apply.h <span style="color: grey">(84b09f5)</span></li>
<li>analitza/apply.cpp <span style="color: grey">(e787372)</span></li>
<li>analitza/container.h <span style="color: grey">(f0deec6)</span></li>
<li>analitza/container.cpp <span style="color: grey">(aabd780)</span></li>
<li>analitza/customobject.h <span style="color: grey">(b6f200c)</span></li>
<li>analitza/customobject.cpp <span style="color: grey">(da8bdb9)</span></li>
<li>analitza/expression.cpp <span style="color: grey">(48fd8d8)</span></li>
<li>analitza/expressiontypechecker.h <span style="color: grey">(8263c2b)</span></li>
<li>analitza/expressiontypechecker.cpp <span style="color: \
grey">(8616127)</span></li>
<li>analitza/expressionwriter.h <span style="color: grey">(ea9c92d)</span></li>
<li>analitza/expressionwriter.cpp <span style="color: grey">(8aff488)</span></li>
<li>analitza/htmlexpressionwriter.h <span style="color: grey">(f8d0060)</span></li>
<li>analitza/htmlexpressionwriter.cpp <span style="color: \
grey">(cf7d4a0)</span></li>
<li>analitza/list.h <span style="color: grey">(9719f9e)</span></li>
<li>analitza/list.cpp <span style="color: grey">(fd1e411)</span></li>
<li>analitza/mathmlexpressionwriter.h <span style="color: \
grey">(70b08ae)</span></li>
<li>analitza/mathmlexpressionwriter.cpp <span style="color: \
grey">(b70a1ca)</span></li>
<li>analitza/mathmlpresentationexpressionwriter.h <span style="color: \
grey">(6c6419e)</span></li>
<li>analitza/mathmlpresentationexpressionwriter.cpp <span style="color: \
grey">(3efc35b)</span></li>
<li>analitza/matrix.h <span style="color: grey">(69c109d)</span></li>
<li>analitza/matrix.cpp <span style="color: grey">(6714ac8)</span></li>
<li>analitza/object.h <span style="color: grey">(aafd114)</span></li>
<li>analitza/object.cpp <span style="color: grey">(b485d07)</span></li>
<li>analitza/operator.h <span style="color: grey">(0e61b21)</span></li>
<li>analitza/operator.cpp <span style="color: grey">(a2d8501)</span></li>
<li>analitza/stringexpressionwriter.h <span style="color: \
grey">(e8c0ccd)</span></li>
<li>analitza/stringexpressionwriter.cpp <span style="color: \
grey">(90594e8)</span></li>
<li>analitza/value.h <span style="color: grey">(89bc2ef)</span></li>
<li>analitza/value.cpp <span style="color: grey">(7d4e49a)</span></li>
<li>analitza/variable.h <span style="color: grey">(2f8514c)</span></li>
<li>analitza/variable.cpp <span style="color: grey">(b98365e)</span></li>
<li>analitza/vector.h <span style="color: grey">(338bf81)</span></li>
<li>analitza/vector.cpp <span style="color: grey">(d7b5836)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115439/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic