'Re: Review Request 115368: KF5 Port - Remove KDebug'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu
Subject:    Re: Review Request 115368: KF5 Port - Remove KDebug
From:       "Laurent Navet" <laurent.navet+kde () gmail ! com>
Date:       2014-01-29 8:20:40
Message-ID: 20140129082040.19065.93508 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On Jan. 29, 2014, 2:52 a.m., Aleix Pol Gonzalez wrote:
> > Ship It!

I dont'have commit rights, so, if someone can push it, thanks!

- Laurent

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115368/#review48509
-----------------------------------------------------------

On Jan. 28, 2014, 9:54 p.m., Laurent Navet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115368/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2014, 9:54 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: klettres
> 
> 
> Description
> -------
> 
> Remove unneeded KDebug which is deprecated in KF5
> 
> 
> Diffs
> -----
> 
>   src/klettres.cpp 9f6ff3f 
>   src/klettresview.cpp d30be34 
>   src/langutils.cpp b41ece2 
>   src/soundfactory.cpp 27dad2e 
> 
> Diff: https://git.reviewboard.kde.org/r/115368/diff/
> 
> 
> Testing
> -------
> 
> build and run
> 
> 
> Thanks,
> 
> Laurent Navet
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115368/">https://git.reviewboard.kde.org/r/115368/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On January 29th, 2014, 2:52 a.m. CET, <b>Aleix Pol \
Gonzalez</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ship It!</pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I dont&#39;have commit \
rights, so, if someone can push it, thanks!</pre> <br />

<p>- Laurent</p>

<br />
<p>On January 28th, 2014, 9:54 p.m. CET, Laurent Navet wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Edu.</div>
<div>By Laurent Navet.</div>

<p style="color: grey;"><i>Updated Jan. 28, 2014, 9:54 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
klettres
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Remove unneeded KDebug which is deprecated in KF5</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">build and run</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/klettres.cpp <span style="color: grey">(9f6ff3f)</span></li>

 <li>src/klettresview.cpp <span style="color: grey">(d30be34)</span></li>

 <li>src/langutils.cpp <span style="color: grey">(b41ece2)</span></li>

 <li>src/soundfactory.cpp <span style="color: grey">(27dad2e)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115368/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 