[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu
Subject: Re: Review Request 114919: Port away answersDialog from KDialog in KGeography
From: "David Gil Oliva" <davidgiloliva () gmail ! com>
Date: 2014-01-09 21:51:58
Message-ID: 20140109215158.16659.25042 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Jan. 9, 2014, 9:21 p.m., Albert Astals Cid wrote:
> > Looks good.
> >
> > Not related to this patch, please have a look at the part of the code that draws \
> > the "Correct answers" label on the left sidebar of the main widget since \
> > something has regressed there over the kde4 version, when you switch to more than \
> > 10 answers the text gets cut.
kgeography.cpp was my next porting and refactoring target, so after the work I will \
check that it works and looks as expected, and otherwise I will fix it.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114919/#review47127
-----------------------------------------------------------
On Jan. 8, 2014, 11:18 p.m., David Gil Oliva wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114919/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2014, 11:18 p.m.)
>
>
> Review request for KDE Edu.
>
>
> Repository: kgeography
>
>
> Description
> -------
>
> Port away from KDialog. Some refactoring. Fix indentation.
>
>
> Diffs
> -----
>
> src/answersdialog.h d2c0f92
> src/answersdialog.cpp d412b1a
>
> Diff: https://git.reviewboard.kde.org/r/114919/diff/
>
>
> Testing
> -------
>
> It builds. It works as expected.
>
>
> Thanks,
>
> David Gil Oliva
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114919/">https://git.reviewboard.kde.org/r/114919/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 9th, 2014, 9:21 p.m. UTC, <b>Albert \
Astals Cid</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Looks good.
Not related to this patch, please have a look at the part of the code that draws the \
"Correct answers" label on the left sidebar of the main widget since \
something has regressed there over the kde4 version, when you switch to more than 10 \
answers the text gets cut.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">kgeography.cpp was my \
next porting and refactoring target, so after the work I will check that it works and \
looks as expected, and otherwise I will fix it.</pre> <br />
<p>- David</p>
<br />
<p>On January 8th, 2014, 11:18 p.m. UTC, David Gil Oliva wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By David Gil Oliva.</div>
<p style="color: grey;"><i>Updated Jan. 8, 2014, 11:18 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kgeography
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Port away from KDialog. Some refactoring. Fix indentation.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It builds. It works as expected.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/answersdialog.h <span style="color: grey">(d2c0f92)</span></li>
<li>src/answersdialog.cpp <span style="color: grey">(d412b1a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114919/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic