[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu
Subject: Re: Review Request 114916: Port away mapChooser from KDialog in KGeography
From: "David Gil Oliva" <davidgiloliva () gmail ! com>
Date: 2014-01-09 9:00:46
Message-ID: 20140109090046.28120.60987 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Jan. 8, 2014, 11:22 p.m., Aleix Pol Gonzalez wrote:
> > src/mapchooser.cpp, line 63
> > <https://git.reviewboard.kde.org/r/114916/diff/1/?file=233570#file233570line63>
> >
> > Do you really need the fixed size?
I actually took it from the original (line 94). I don't have an opinion here.
> On Jan. 8, 2014, 11:22 p.m., Aleix Pol Gonzalez wrote:
> > src/mapchooser.cpp, line 83
> > <https://git.reviewboard.kde.org/r/114916/diff/1/?file=233570#file233570line83>
> >
> > Initialize! Or even better, make it a more local scope, no?
I haven't refactored from line 64 on of the constructor. I have left it for another \
patch after the port to KF5 is finished. In fact, I think most of the code from line \
64 on should be in another method.
On Jan. 8, 2014, 11:22 p.m., David Gil Oliva wrote:
> > First time I see spaces around "->" :)
So didn't I! I had once heard of it, but never seen it.
I didn't change it because I didn't want to touch the whole file (and because perhaps \
it was a matter of taste of the author...)
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114916/#review47091
-----------------------------------------------------------
On Jan. 8, 2014, 10:07 p.m., David Gil Oliva wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114916/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2014, 10:07 p.m.)
>
>
> Review request for KDE Edu.
>
>
> Repository: kgeography
>
>
> Description
> -------
>
> Ports away from KDialog. Some refactoring.
>
>
> Diffs
> -----
>
> src/mapchooser.h 138b322
> src/mapchooser.cpp 486d85c
>
> Diff: https://git.reviewboard.kde.org/r/114916/diff/
>
>
> Testing
> -------
>
> It builds and it works as expected.
>
>
> Thanks,
>
> David Gil Oliva
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114916/">https://git.reviewboard.kde.org/r/114916/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 8th, 2014, 11:22 p.m. UTC, <b>Aleix Pol \
Gonzalez</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/114916/diff/1/?file=233570#file233570line63" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/mapchooser.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">51</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="n">p_imageContainer</span> <span \
class="o">-></span> <span class="n">setFixedSize</span><span \
class="p">(</span><span class="mi">300</span><span class="p">,</span> <span \
class="mi">225</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Do you really need the \
fixed size?</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I actually \
took it from the original (line 94). I don't have an opinion here.</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 8th, 2014, 11:22 p.m. UTC, <b>Aleix Pol \
Gonzalez</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/114916/diff/1/?file=233570#file233570line83" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/mapchooser.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">71</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="n">KGmap</span> <span class="o">*</span><span \
class="n">m</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Initialize! Or even \
better, make it a more local scope, no?</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I \
haven't refactored from line 64 on of the constructor. I have left it for another \
patch after the port to KF5 is finished. In fact, I think most of the code from line \
64 on should be in another method.</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 8th, 2014, 11:22 p.m. UTC, <b>Aleix Pol \
Gonzalez</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">First time I see spaces around "->" :)</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">So didn't I! I had \
once heard of it, but never seen it.
I didn't change it because I didn't want to touch the whole file (and because \
perhaps it was a matter of taste of the author...)</pre> <br />
<p>- David</p>
<br />
<p>On January 8th, 2014, 10:07 p.m. UTC, David Gil Oliva wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By David Gil Oliva.</div>
<p style="color: grey;"><i>Updated Jan. 8, 2014, 10:07 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kgeography
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ports away from KDialog. Some refactoring.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It builds and it works as expected.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/mapchooser.h <span style="color: grey">(138b322)</span></li>
<li>src/mapchooser.cpp <span style="color: grey">(486d85c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114916/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic