From kde-edu Sat Dec 28 02:06:56 2013 From: "Yichao Yu" Date: Sat, 28 Dec 2013 02:06:56 +0000 To: kde-edu Subject: Re: Review Request 114006: Update min and max value at the same time in order to be more friendly wi Message-Id: <20131228020656.27341.12796 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-edu&m=138819644002705 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============7185980312727306730==" --===============7185980312727306730== Content-Type: multipart/alternative; boundary="===============4195052050220213499==" --===============4195052050220213499== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On Dec. 27, 2013, 11:46 a.m., Albert Astals Cid wrote: > > I can't seem to find any problem with the current code (i.e. without the patch). Can you explain exactly (step by step) what you do and in which point you find something that you think it can be improved usability-wise? > > Yichao Yu wrote: > Double click a element (e.g. Lithium). > In the popup window, select Spectrum tab > Select and type 670 in Minimum value > Select and type 671 in Maximum value > > Now the spectrum range shown is sth like 5nm-671nm instead of 60-671nm. > This patch makes that 670-671nm > (I mean "instead of 670-671nm") - Yichao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114006/#review46205 ----------------------------------------------------------- On Nov. 21, 2013, 2:20 p.m., Yichao Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114006/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2013, 2:20 p.m.) > > > Review request for KDE Edu, Laurent Montel and Jeremy Whiting. > > > Repository: kalzium > > > Description > ------- > > This patch makes the behavior while typing in the min/max boxes more friendly. > > Currently if one types in the maximum value box, the minimum value will stuck at a small value due to the small value in the maximum value box before one finish typing. (I don't really call this a bug, but I think it is not friendly.) > > This patch tries to update both the maximum and minimum values whenever one of them changes (in the right order to always respect the one that changes) so that the actual range displayed is always the closed possible to the input values. It also covers the cases when min/max values change from illegal values to legal values (max > min) in some other ways. > > > Diffs > ----- > > src/spectrumviewimpl.h c596154 > src/spectrumviewimpl.cpp 0327202 > src/spectrumwidget.h 5117d26 > > Diff: https://git.reviewboard.kde.org/r/114006/diff/ > > > Testing > ------- > > Compiles and fixes the problem. > > > Thanks, > > Yichao Yu > > --===============4195052050220213499== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114006/

On December 27th, 2013, 11:46 a.m. EST, Albert Astals Cid wrote:

I can't seem to find any problem with the current code (i.e. without the patch). Can you explain exactly (step by step) what you do and in which point you find something that you think it can be improved usability-wise?

On December 27th, 2013, 9:05 p.m. EST, Yichao Yu wrote:

Double click a element (e.g. Lithium).
In the popup window, select Spectrum tab
Select and type 670 in Minimum value
Select and type 671 in Maximum value

Now the spectrum range shown is sth like 5nm-671nm instead of 60-671nm.
This patch makes that 670-671nm

(I mean "instead of 670-671nm")

- Yichao

On November 21st, 2013, 2:20 p.m. EST, Yichao Yu wrote:

Review request for KDE Edu, Laurent Montel and Jeremy Whiting.

By Yichao Yu.

Updated Nov. 21, 2013, 2:20 p.m.

Repository: kalzium

Description

This patch makes the behavior while typing in the min/max boxes more friendly.

Currently if one types in the maximum value box, the minimum value will stuck at a small value due to the small value in the maximum value box before one finish typing. (I don't really call this a bug, but I think it is not friendly.)

This patch tries to update both the maximum and minimum values whenever one of them changes (in the right order to always respect the one that changes) so that the actual range displayed is always the closed possible to the input values. It also covers the cases when min/max values change from illegal values to legal values (max > min) in some other ways.

Testing

Compiles and fixes the problem.

Diffs

src/spectrumviewimpl.h (c596154)
src/spectrumviewimpl.cpp (0327202)
src/spectrumwidget.h (5117d26)

--===============4195052050220213499==-- --===============7185980312727306730== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kde-edu mailing list kde-edu@mail.kde.org https://mail.kde.org/mailman/listinfo/kde-edu --===============7185980312727306730==--