'Re: Review Request 113660: filter the list of maps'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu
Subject:    Re: Review Request 113660: filter the list of maps
From:       "Albert Astals Cid" <aacid () kde ! org>
Date:       2013-11-11 21:50:44
Message-ID: 20131111215044.24590.14126 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113660/#review43468
-----------------------------------------------------------

Ship it!

Good!

- Albert Astals Cid

On Nov. 11, 2013, 5:19 p.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113660/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2013, 5:19 p.m.)
> 
> 
> Review request for KDE Edu and Albert Astals Cid.
> 
> 
> Bugs: 319974
>     http://bugs.kde.org/show_bug.cgi?id=319974
> 
> 
> Repository: kgeography
> 
> 
> Description
> -------
> 
> Change from QListWidget to QListView because QListWidget setModel() is private :-(
> Implemented an eventFilter to make QListView behave like a QListWidget.
> Implemented a filterProxyModel to filter the list (by the first letters).
> 
> Is the text inside the KLineEdit right?
> Should it filter by first letters or any letter?
> 
> 
> Diffs
> -----
> 
>   src/mapchooser.cpp c2bf8ec 
> 
> Diff: http://git.reviewboard.kde.org/r/113660/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jaime Torres Amate
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/113660/">http://git.reviewboard.kde.org/r/113660/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Good!</pre>  <br />

<p>- Albert Astals Cid</p>

<br />
<p>On November 11th, 2013, 5:19 p.m. UTC, Jaime Torres Amate wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Edu and Albert Astals Cid.</div>
<div>By Jaime Torres Amate.</div>

<p style="color: grey;"><i>Updated Nov. 11, 2013, 5:19 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=319974">319974</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kgeography
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Change from QListWidget to QListView because QListWidget setModel() is \
private :-( Implemented an eventFilter to make QListView behave like a QListWidget.
Implemented a filterProxyModel to filter the list (by the first letters).

Is the text inside the KLineEdit right?
Should it filter by first letters or any letter?</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/mapchooser.cpp <span style="color: grey">(c2bf8ec)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/113660/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 