[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu
Subject: Re: Review Request 113382: Number of answers always in the same place, and with a maximum width.
From: "Albert Astals Cid" <aacid () kde ! org>
Date: 2013-10-22 16:53:10
Message-ID: 20131022165310.6484.47289 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113382/#review42165
-----------------------------------------------------------
Ship it!
Good stuff, If you get bored maybe you can do https://bugs.kde.org/show_bug.cgi?id=319974 \
shouldn't be too hard ;-)
- Albert Astals Cid
On Oct. 22, 2013, 3:22 p.m., Jaime Torres Amate wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113382/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2013, 3:22 p.m.)
>
>
> Review request for KDE Edu and Albert Astals Cid.
>
>
> Repository: kgeography
>
>
> Description
> -------
>
> Create another invisible widget bellow underLeftWidget, with a stretch(1). In that way, the \
> label with the number of answers is always in the same place. Also, setting a maximum width \
> to leftWidget (once everything is shown), the label will use the wordwrap instead of \
> expanding the layout (it is quite disgusting for me to see the map moving from question to \
> question, specially in place regions in the map).
> (as allways, the red white spaces are already removed).
>
>
> Diffs
> -----
>
> src/boxasker.cpp 123efef
> src/kgeography.cpp b8f2c0d
>
> Diff: http://git.reviewboard.kde.org/r/113382/diff/
>
>
> Testing
> -------
>
> Previously:
> If you used a map like Georgia, with Place regions in the Map, in the turn of \
> "Racha-Lechkhumi and Kvemo Svaneti", the map got displaced. If you used Regions by Capital \
> two times, the second time, the label with the number of answers were not on the same place.
> After:
> The large names will not displace the map and the label will always be in the same place, no \
> matter what the questions are.
>
> Thanks,
>
> Jaime Torres Amate
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113382/">http://git.reviewboard.kde.org/r/113382/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Good stuff, If you get bored maybe you can do \
https://bugs.kde.org/show_bug.cgi?id=319974 shouldn't be too hard ;-)</pre> <br />
<p>- Albert Astals Cid</p>
<br />
<p>On October 22nd, 2013, 3:22 p.m. UTC, Jaime Torres Amate wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for KDE Edu and Albert Astals Cid.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated Oct. 22, 2013, 3:22 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kgeography
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Create another \
invisible widget bellow underLeftWidget, with a stretch(1). In that way, the label with the \
number of answers is always in the same place. Also, setting a maximum width to leftWidget \
(once everything is shown), the label will use the wordwrap instead of expanding the layout (it \
is quite disgusting for me to see the map moving from question to question, specially in place \
regions in the map).
(as allways, the red white spaces are already removed).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Previously: If you \
used a map like Georgia, with Place regions in the Map, in the turn of "Racha-Lechkhumi \
and Kvemo Svaneti", the map got displaced. If you used Regions by Capital two times, the \
second time, the label with the number of answers were not on the same place.
After:
The large names will not displace the map and the label will always be in the same place, no \
matter what the questions are.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/boxasker.cpp <span style="color: grey">(123efef)</span></li>
<li>src/kgeography.cpp <span style="color: grey">(b8f2c0d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113382/diff/" style="margin-left: 3em;">View \
Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic