'Re: Review Request 113096: No artifacts when the scrollbars are shown and used to jump to the right'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu
Subject:    Re: Review Request 113096: No artifacts when the scrollbars are shown and used to jump to the right
From:       "Albert Astals Cid" <aacid () kde ! org>
Date:       2013-10-13 22:04:33
Message-ID: 20131013220433.4290.64457 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113096/#review41668
-----------------------------------------------------------

Looks good, since it's a bit of a "big change" maybe it's better if you only commit to master \
just in case something breaks. What do you think?

src/mapwidget.h
<http://git.reviewboard.kde.org/r/113096/#comment30448>

    Remove this

- Albert Astals Cid

On Oct. 10, 2013, 11:32 a.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113096/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2013, 11:32 a.m.)
> 
> 
> Review request for KDE Edu and Albert Astals Cid.
> 
> 
> Repository: kgeography
> 
> 
> Description
> -------
> 
> Just paint the background white and then draw the image.
> 
> 
> Diffs
> -----
> 
> src/mapwidget.h 1211d2c 
> src/mapwidget.cpp 57ab716 
> 
> Diff: http://git.reviewboard.kde.org/r/113096/diff/
> 
> 
> Testing
> -------
> 
> Before: In big maps like Portugal, when the scrollbars appear, and you click in the right \
> part of the scrollbar (or the lowest for vertical), to jump to the lower right corner, you \
>                 could see rendering artifacts.
> Now: No artifacts, just white.
> 
> 
> File Attachments
> ----------------
> 
> screen capture
> http://git.reviewboard.kde.org/media/uploaded/files/2013/10/08/50cc156b-25d1-4c08-859c-534a9dfaf702__kgeography_problem.png
>  
> 
> Thanks,
> 
> Jaime Torres Amate
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/113096/">http://git.reviewboard.kde.org/r/113096/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Looks good, since it&#39;s a bit of a \
&quot;big change&quot; maybe it&#39;s better if you only commit to master just in case \
something breaks. What do you think?</pre>  <br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; \
padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/113096/diff/2/?file=200253#file200253line50" \
style="color: black; font-weight: bold; text-decoration: underline;">src/mapwidget.h</a>  <span \
style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">Q_OBJECT</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">50</font></th>  <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; \
line-height: 140%; margin: 0; "><span class="tb">	</span><span class="tb">	</span><span \
class="kt">void</span> <span class="nf">drawBackground</span><span class="p">(</span><span \
class="n">QPainter</span> <span class="o">*</span><span class="n">painter</span><span \
class="p">,</span> <span class="k">const</span> <span class="n">QRectF</span> <span \
class="o">&amp;</span><span class="n">rect</span><span class="p">);</span></pre></td>  <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">50</font></th>  <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c1"><span \
class="hl">//</span><span class="tb">	</span><span class="tb">	</span>void \
drawBackground(QPainter *painter, const QRectF &amp;rect);</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove this</pre> </div>
<br />

<p>- Albert Astals Cid</p>

<br />
<p>On October 10th, 2013, 11:32 a.m. UTC, Jaime Torres Amate wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for KDE Edu and Albert Astals Cid.</div>
<div>By Jaime Torres Amate.</div>

<p style="color: grey;"><i>Updated Oct. 10, 2013, 11:32 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kgeography
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just paint the \
background white and then draw the image. </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Before: In big maps \
like Portugal, when the scrollbars appear, and you click in the right part of the scrollbar (or \
                the lowest for vertical), to jump to the lower right corner, you could see \
                rendering artifacts.
Now: No artifacts, just white.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/mapwidget.h <span style="color: grey">(1211d2c)</span></li>

 <li>src/mapwidget.cpp <span style="color: grey">(57ab716)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/113096/diff/" style="margin-left: 3em;">View \
Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>

<ul>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/10/08/50cc156b-25d1-4c08-859c-534a9dfaf702__kgeography_problem.png">screen \
capture</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 