[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu
Subject: Re: Review Request 113096: No artifacts when the scrollbars are shown and used to jump to the right
From: "Albert Astals Cid" <aacid () kde ! org>
Date: 2013-10-09 23:27:55
Message-ID: 20131009232755.19989.96215 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113096/#review41471
-----------------------------------------------------------
Ok, i see the issue now, could not reproduce before, now the question is, shouldn't we be \
fixing the math or something? what's the point that when you're zoomed in like that there is a \
white space around the image? I mean it's unless whitespace, no?
- Albert Astals Cid
On Oct. 8, 2013, 7:23 p.m., Jaime Torres Amate wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113096/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2013, 7:23 p.m.)
>
>
> Review request for KDE Edu and Albert Astals Cid.
>
>
> Repository: kgeography
>
>
> Description
> -------
>
> Just paint the background white and then draw the image.
>
>
> Diffs
> -----
>
> src/mapwidget.cpp 57ab716
>
> Diff: http://git.reviewboard.kde.org/r/113096/diff/
>
>
> Testing
> -------
>
> Before: In big maps like Portugal, when the scrollbars appear, and you click in the right \
> part of the scrollbar (or the lowest for vertical), to jump to the lower right corner, you \
> could see rendering artifacts.
> Now: No artifacts, just white.
>
>
> File Attachments
> ----------------
>
> screen capture
> http://git.reviewboard.kde.org/media/uploaded/files/2013/10/08/50cc156b-25d1-4c08-859c-534a9dfaf702__kgeography_problem.png
>
>
> Thanks,
>
> Jaime Torres Amate
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113096/">http://git.reviewboard.kde.org/r/113096/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Ok, i see the issue now, could not reproduce \
before, now the question is, shouldn't we be fixing the math or something? what's the \
point that when you're zoomed in like that there is a white space around the image? I mean \
it's unless whitespace, no?</pre> <br />
<p>- Albert Astals Cid</p>
<br />
<p>On October 8th, 2013, 7:23 p.m. UTC, Jaime Torres Amate wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for KDE Edu and Albert Astals Cid.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated Oct. 8, 2013, 7:23 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kgeography
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just paint the \
background white and then draw the image. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Before: In big maps \
like Portugal, when the scrollbars appear, and you click in the right part of the scrollbar (or \
the lowest for vertical), to jump to the lower right corner, you could see \
rendering artifacts.
Now: No artifacts, just white.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/mapwidget.cpp <span style="color: grey">(57ab716)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113096/diff/" style="margin-left: 3em;">View \
Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/10/08/50cc156b-25d1-4c08-859c-534a9dfaf702__kgeography_problem.png">screen \
capture</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic