From kde-edu Mon Aug 19 13:16:03 2013 From: "Frederik Gladhorn" Date: Mon, 19 Aug 2013 13:16:03 +0000 To: kde-edu Subject: Re: Review Request 112154: Make it possible to edit language settings in practice mode Message-Id: <20130819131603.14718.74019 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-edu&m=137691818230627 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1313862485368502805==" --===============1313862485368502805== Content-Type: multipart/alternative; boundary="===============6637195277674310129==" --===============6637195277674310129== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112154/#review38135 ----------------------------------------------------------- Ship it! src/editor/editor.cpp This seems unrelated (newline?) to the rest of the patch. Seems good, apart from the extra newline which should be removed. Thanks. - Frederik Gladhorn On Aug. 19, 2013, 11:11 a.m., Inge Wallin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112154/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2013, 11:11 a.m.) > > > Review request for KDE Edu and Frederik Gladhorn. > > > Description > ------- > > Currently Parley has a setting for editing language settings such as fontsize in the editor and practice and also other, more language specific things. But this is extremely well hidden in the editor mode only and under the Edit menu. > > This patch makes the language settings available also during practice. > > You could argue that settings for the language itself should be separated from viewing settings but this is not the topic of this patch. > > > Diffs > ----- > > src/editor/editor.cpp 6511a69 > src/practice/practicemainwindow.cpp 9f23ae9 > src/practice/practiceui.rc 96c4a06 > > Diff: http://git.reviewboard.kde.org/r/112154/diff/ > > > Testing > ------- > > > Thanks, > > Inge Wallin > > --===============6637195277674310129== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112154/

Ship it!

src/editor/editor.cpp (Diff revision 1)
void EditorWindow::initActions()
		364	SLOT(languageProperties()), actionCollection());

This seems unrelated (newline?) to the rest of the patch.

Seems good, apart from the extra newline which should be removed. Thanks.

- Frederik

On August 19th, 2013, 11:11 a.m. UTC, Inge Wallin wrote:

Review request for KDE Edu and Frederik Gladhorn.

By Inge Wallin.

Updated Aug. 19, 2013, 11:11 a.m.

Description

Currently Parley has a setting for editing language settings such as fontsize in the editor and practice and also other, more language specific things.  But this is extremely well hidden in the editor mode only and under the Edit menu.

This patch makes the language settings available also during practice.

You could argue that settings for the language itself should be separated from viewing settings but this is not the topic of this patch.

Diffs

src/editor/editor.cpp (6511a69)
src/practice/practicemainwindow.cpp (9f23ae9)
src/practice/practiceui.rc (96c4a06)

--===============6637195277674310129==-- --===============1313862485368502805== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kde-edu mailing list kde-edu@mail.kde.org https://mail.kde.org/mailman/listinfo/kde-edu --===============1313862485368502805==--