[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu
Subject: Re: Review Request 111470: Allow loading google images plugin on non-ASCII locales
From: "Yuri Chornoivan" <yurchor () ukr ! net>
Date: 2013-07-21 16:14:28
Message-ID: 20130721161428.26170.76393 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On July 21, 2013, 3:58 p.m., Albert Astals Cid wrote:
> > plugins/google_images.py, line 250
> > <http://git.reviewboard.kde.org/r/111470/diff/1/?file=169754#file169754line250>
> >
> > I'm not much into python, but seems to me that instead of adding the toUtf8 it'd \
> > be simpler to remove the str() (if that works of course :D)
No. This does not work:
/usr/share/apps/parley/plugins/google_images.py, ????? 250:
Setting attribute "statusTip" failed.
Backtrace:
File "/usr/share/apps/parley/plugins/google_images.py", line 250, in <module>
action1.statusTip = i18n("Fetches an image for the selected translation")
- Yuri
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111470/#review36254
-----------------------------------------------------------
On July 10, 2013, 6:11 a.m., Yuri Chornoivan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111470/
> -----------------------------------------------------------
>
> (Updated July 10, 2013, 6:11 a.m.)
>
>
> Review request for KDE Edu and Frederik Gladhorn.
>
>
> Description
> -------
>
> Parley Google images plugin fails to load in Ukrainian (Cyrillic) with the message:
>
> /usr/share/apps/parley/plugins/google_images.py, line 250:
> 'ascii' codec can't encode characters in position 0-6: ordinal not in range(128)
> Backtrace:
> File "/usr/share/apps/parley/plugins/google_images.py", line 250, in <module>
> action1.statusTip = str(i18n("Fetches an image for the selected translation"))
>
> This patch tries to avoid this inconvenience.
>
>
> Diffs
> -----
>
> plugins/google_images.py 5317ba6
>
> Diff: http://git.reviewboard.kde.org/r/111470/diff/
>
>
> Testing
> -------
>
> No errors while loading editor. Plugin does not work anyway, but it's a different \
> story. ;)
>
> Thanks,
>
> Yuri Chornoivan
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111470/">http://git.reviewboard.kde.org/r/111470/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 21st, 2013, 3:58 p.m. UTC, <b>Albert \
Astals Cid</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/111470/diff/1/?file=169754#file169754line250" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plugins/google_images.py</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">def \
fetchImage():</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">250</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="n">action1</span><span class="o">.</span><span class="n">statusTip</span> \
<span class="o">=</span> <span class="nb">str</span><span class="p">(</span><span \
class="n">i18n</span><span class="p">(</span><span class="s">"Fetches an image \
for the selected translation"</span><span class="p">)<span \
class="hl">)</span></span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">250</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="n">action1</span><span \
class="o">.</span><span class="n">statusTip</span> <span class="o">=</span> <span \
class="nb">str</span><span class="p">(</span><span class="n">i18n</span><span \
class="p">(</span><span class="s">"Fetches an image for the selected \
translation"</span><span class="p">)</span><span class="o"><span \
class="hl">.</span></span><span class="n"><span class="hl">toUtf8</span></span><span \
class="p"><span class="hl">())</span></span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not much into \
python, but seems to me that instead of adding the toUtf8 it'd be simpler to \
remove the str() (if that works of course :D)</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No. This \
does not work:
/usr/share/apps/parley/plugins/google_images.py, ????? 250:
Setting attribute "statusTip" failed.
Backtrace:
File "/usr/share/apps/parley/plugins/google_images.py", line 250, in \
<module> action1.statusTip = i18n("Fetches an image for the selected \
translation") </pre>
<br />
<p>- Yuri</p>
<br />
<p>On July 10th, 2013, 6:11 a.m. UTC, Yuri Chornoivan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu and Frederik Gladhorn.</div>
<div>By Yuri Chornoivan.</div>
<p style="color: grey;"><i>Updated July 10, 2013, 6:11 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Parley Google images plugin fails to load in Ukrainian (Cyrillic) with \
the message:
/usr/share/apps/parley/plugins/google_images.py, line 250:
'ascii' codec can't encode characters in position 0-6: ordinal not in \
range(128) Backtrace:
File "/usr/share/apps/parley/plugins/google_images.py", line 250, in \
<module> action1.statusTip = str(i18n("Fetches an image for the selected \
translation"))
This patch tries to avoid this inconvenience.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">No errors while loading editor. Plugin does not work anyway, but \
it's a different story. ;)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/google_images.py <span style="color: grey">(5317ba6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111470/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic