'Re: Review Request 111470: Allow loading google images plugin on non-ASCII locales'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu
Subject:    Re: Review Request 111470: Allow loading google images plugin on non-ASCII locales
From:       "Frederik Gladhorn" <gladhorn () kde ! org>
Date:       2013-07-10 17:43:25
Message-ID: 20130710174325.2614.70483 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111470/#review35847
-----------------------------------------------------------

Should the same not be applied to all other messages in the file?

- Frederik Gladhorn

On July 10, 2013, 6:11 a.m., Yuri Chornoivan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111470/
> -----------------------------------------------------------
> 
> (Updated July 10, 2013, 6:11 a.m.)
> 
> 
> Review request for KDE Edu and Frederik Gladhorn.
> 
> 
> Description
> -------
> 
> Parley Google images plugin fails to load in Ukrainian (Cyrillic) with the message:
> 
> /usr/share/apps/parley/plugins/google_images.py, line 250:
> 'ascii' codec can't encode characters in position 0-6: ordinal not in range(128)
> Backtrace:
> File "/usr/share/apps/parley/plugins/google_images.py", line 250, in <module>
> action1.statusTip = str(i18n("Fetches an image for the selected translation"))
> 
> This patch tries to avoid this inconvenience.
> 
> 
> Diffs
> -----
> 
>   plugins/google_images.py 5317ba6 
> 
> Diff: http://git.reviewboard.kde.org/r/111470/diff/
> 
> 
> Testing
> -------
> 
> No errors while loading editor. Plugin does not work anyway, but it's a different story. ;)
> 
> 
> Thanks,
> 
> Yuri Chornoivan
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/111470/">http://git.reviewboard.kde.org/r/111470/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Should the same not be \
applied to all other messages in the file?</pre>  <br />

<p>- Frederik</p>

<br />
<p>On July 10th, 2013, 6:11 a.m. UTC, Yuri Chornoivan wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Edu and Frederik Gladhorn.</div>
<div>By Yuri Chornoivan.</div>

<p style="color: grey;"><i>Updated July 10, 2013, 6:11 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Parley Google images plugin fails to load in Ukrainian (Cyrillic) with \
the message:

/usr/share/apps/parley/plugins/google_images.py, line 250:
&#39;ascii&#39; codec can&#39;t encode characters in position 0-6: ordinal not in \
range(128) Backtrace:
File &quot;/usr/share/apps/parley/plugins/google_images.py&quot;, line 250, in \
&lt;module&gt; action1.statusTip = str(i18n(&quot;Fetches an image for the selected \
translation&quot;))

This patch tries to avoid this inconvenience.
</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">No errors while loading editor. Plugin does not work anyway, but \
it&#39;s a different story. ;)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plugins/google_images.py <span style="color: grey">(5317ba6)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/111470/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 