[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu
Subject: Re: Review Request: Normalizing SIGNAL and SLOT signatures
From: "Kevin Krammer" <krammer () kde ! org>
Date: 2013-01-04 14:18:54
Message-ID: 20130104141854.10806.76263 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108094/#review24665
-----------------------------------------------------------
Ship it!
I fixed the build errors before committing.
In two instances they were caused by explicit on "upgrade" constructors, i.=
e. a subclass being initialzed through an instance of a base class. e.g. Ge=
oDataLinearRing being initialized with a GeoDataLineString instance.
I've reverted the explicits for those cases, someone from Marble's develope=
r team needs to check if those convertions are wanted and if yes mark the l=
ine with a krazy exclude.
Another cause was a missing include in a file that got QtCore module includ=
e replaced by individual includes. Fixed by adding the missing include.
- Kevin Krammer
On Jan. 3, 2013, 6:24 p.m., Mayank Madan wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108094/
> -----------------------------------------------------------
> =
> (Updated Jan. 3, 2013, 6:24 p.m.)
> =
> =
> Review request for KDE Edu, Kevin Krammer and Torsten Rahn.
> =
> =
> Description
> -------
> =
> Fixing SIGNAL/SLOT signatures to normalized form as reported by Krazy
> =
> =
> Diffs
> -----
> =
> src/lib/MarbleMap.cpp 14f20dc =
> src/lib/TileCoordsPyramid.h b669e6c =
> src/lib/geodata/data/GeoDataContainer.h 8cb94cb =
> src/lib/geodata/data/GeoDataLatLonAltBox.h 7276842 =
> src/lib/geodata/data/GeoDataLineString.h 1f833d0 =
> src/lib/geodata/data/GeoDataLinearRing.h 9cfce6d =
> src/lib/geodata/data/GeoDataMultiGeometry.h 00f775f =
> src/lib/geodata/data/GeoDataMultiTrack.h d929da8 =
> src/lib/geodata/data/GeoDataPlacemark.h 5dcfe6a =
> src/lib/geodata/data/GeoDataPoint.h 2e8df39 =
> src/lib/geodata/data/GeoDataPolygon.h 788f19e =
> src/lib/geodata/data/GeoDataTrack.h 98d8819 =
> src/plugins/declarative/Bookmarks.cpp 4319aab =
> src/plugins/declarative/DeclarativeDataPlugin.cpp 8cd54f9 =
> src/plugins/declarative/MapThemeModel.cpp 47bc226 =
> src/plugins/declarative/Navigation.cpp 8636101 =
> src/plugins/declarative/OfflineDataModel.cpp 181319a =
> src/plugins/declarative/PositionSource.cpp 03bb401 =
> src/plugins/declarative/RouteRequestModel.cpp aae7ff1 =
> src/plugins/declarative/Routing.cpp 7147d47 =
> src/plugins/declarative/Search.cpp 5bf98e2 =
> src/plugins/render/navigation/ArrowDiscWidget.h ad88852 =
> src/plugins/render/satellites/SatellitesMSCItem.cpp 465d1b9 =
> src/plugins/render/satellites/TrackerPluginItem.h c88e1ef =
> src/plugins/render/twitter/twitterPlugin.cpp 81cbc30 =
> src/plugins/render/weather/BBCParser.h e1ca1e5 =
> src/plugins/runner/json/JsonParser.h 947f7df =
> src/plugins/runner/json/JsonParser.cpp fc5eadf =
> src/plugins/runner/local-osm-search/DatabaseQuery.h 0f8809d =
> src/plugins/runner/local-osm-search/OsmDatabase.cpp 12d027e =
> src/plugins/runner/osm/handlers/OsmNodeFactory.h 25d17ad =
> src/plugins/runner/osm/handlers/OsmNodeFactory.cpp df25c95 =
> src/plugins/runner/osm/handlers/OsmRelationFactory.h a4c5f61 =
> src/plugins/runner/osm/handlers/OsmRelationFactory.cpp f1e9fdc =
> src/plugins/runner/osm/handlers/OsmRelationTagHandler.cpp 892df17 =
> src/plugins/runner/osm/handlers/OsmWayFactory.h d3f3126 =
> src/plugins/runner/osm/handlers/OsmWayFactory.cpp a709ae5 =
> src/plugins/runner/osm/handlers/OsmWayTagHandler.cpp 1fc753c =
> src/plugins/runner/pn2/Pn2Runner.cpp 767911f =
> =
> Diff: http://git.reviewboard.kde.org/r/108094/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Mayank Madan
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108094/">http://git.reviewboard.kde.org/r/108094/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">I fixed the build errors before committing.
In two instances they were caused by explicit on "upgrade" constructors, i.e. a subclass being \
initialzed through an instance of a base class. e.g. GeoDataLinearRing being initialized with a \
GeoDataLineString instance. I've reverted the explicits for those cases, someone from Marble's \
developer team needs to check if those convertions are wanted and if yes mark the line with a krazy \
exclude.
Another cause was a missing include in a file that got QtCore module include replaced by individual \
includes. Fixed by adding the missing include.</pre> <br />
<p>- Kevin</p>
<br />
<p>On January 3rd, 2013, 6:24 p.m., Mayank Madan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: \
left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for KDE Edu, Kevin Krammer and Torsten Rahn.</div>
<div>By Mayank Madan.</div>
<p style="color: grey;"><i>Updated Jan. 3, 2013, 6:24 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixing SIGNAL/SLOT signatures to normalized \
form as reported by Krazy</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/MarbleMap.cpp <span style="color: grey">(14f20dc)</span></li>
<li>src/lib/TileCoordsPyramid.h <span style="color: grey">(b669e6c)</span></li>
<li>src/lib/geodata/data/GeoDataContainer.h <span style="color: grey">(8cb94cb)</span></li>
<li>src/lib/geodata/data/GeoDataLatLonAltBox.h <span style="color: grey">(7276842)</span></li>
<li>src/lib/geodata/data/GeoDataLineString.h <span style="color: grey">(1f833d0)</span></li>
<li>src/lib/geodata/data/GeoDataLinearRing.h <span style="color: grey">(9cfce6d)</span></li>
<li>src/lib/geodata/data/GeoDataMultiGeometry.h <span style="color: grey">(00f775f)</span></li>
<li>src/lib/geodata/data/GeoDataMultiTrack.h <span style="color: grey">(d929da8)</span></li>
<li>src/lib/geodata/data/GeoDataPlacemark.h <span style="color: grey">(5dcfe6a)</span></li>
<li>src/lib/geodata/data/GeoDataPoint.h <span style="color: grey">(2e8df39)</span></li>
<li>src/lib/geodata/data/GeoDataPolygon.h <span style="color: grey">(788f19e)</span></li>
<li>src/lib/geodata/data/GeoDataTrack.h <span style="color: grey">(98d8819)</span></li>
<li>src/plugins/declarative/Bookmarks.cpp <span style="color: grey">(4319aab)</span></li>
<li>src/plugins/declarative/DeclarativeDataPlugin.cpp <span style="color: grey">(8cd54f9)</span></li>
<li>src/plugins/declarative/MapThemeModel.cpp <span style="color: grey">(47bc226)</span></li>
<li>src/plugins/declarative/Navigation.cpp <span style="color: grey">(8636101)</span></li>
<li>src/plugins/declarative/OfflineDataModel.cpp <span style="color: grey">(181319a)</span></li>
<li>src/plugins/declarative/PositionSource.cpp <span style="color: grey">(03bb401)</span></li>
<li>src/plugins/declarative/RouteRequestModel.cpp <span style="color: grey">(aae7ff1)</span></li>
<li>src/plugins/declarative/Routing.cpp <span style="color: grey">(7147d47)</span></li>
<li>src/plugins/declarative/Search.cpp <span style="color: grey">(5bf98e2)</span></li>
<li>src/plugins/render/navigation/ArrowDiscWidget.h <span style="color: grey">(ad88852)</span></li>
<li>src/plugins/render/satellites/SatellitesMSCItem.cpp <span style="color: grey">(465d1b9)</span></li>
<li>src/plugins/render/satellites/TrackerPluginItem.h <span style="color: grey">(c88e1ef)</span></li>
<li>src/plugins/render/twitter/twitterPlugin.cpp <span style="color: grey">(81cbc30)</span></li>
<li>src/plugins/render/weather/BBCParser.h <span style="color: grey">(e1ca1e5)</span></li>
<li>src/plugins/runner/json/JsonParser.h <span style="color: grey">(947f7df)</span></li>
<li>src/plugins/runner/json/JsonParser.cpp <span style="color: grey">(fc5eadf)</span></li>
<li>src/plugins/runner/local-osm-search/DatabaseQuery.h <span style="color: grey">(0f8809d)</span></li>
<li>src/plugins/runner/local-osm-search/OsmDatabase.cpp <span style="color: grey">(12d027e)</span></li>
<li>src/plugins/runner/osm/handlers/OsmNodeFactory.h <span style="color: grey">(25d17ad)</span></li>
<li>src/plugins/runner/osm/handlers/OsmNodeFactory.cpp <span style="color: grey">(df25c95)</span></li>
<li>src/plugins/runner/osm/handlers/OsmRelationFactory.h <span style="color: grey">(a4c5f61)</span></li>
<li>src/plugins/runner/osm/handlers/OsmRelationFactory.cpp <span style="color: \
grey">(f1e9fdc)</span></li>
<li>src/plugins/runner/osm/handlers/OsmRelationTagHandler.cpp <span style="color: \
grey">(892df17)</span></li>
<li>src/plugins/runner/osm/handlers/OsmWayFactory.h <span style="color: grey">(d3f3126)</span></li>
<li>src/plugins/runner/osm/handlers/OsmWayFactory.cpp <span style="color: grey">(a709ae5)</span></li>
<li>src/plugins/runner/osm/handlers/OsmWayTagHandler.cpp <span style="color: grey">(1fc753c)</span></li>
<li>src/plugins/runner/pn2/Pn2Runner.cpp <span style="color: grey">(767911f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108094/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic