[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu
Subject: Re: Review Request: Set Antialiasing in Kig
From: David_Narváez <david.narvaez () computer ! org>
Date: 2012-04-19 5:28:28
Message-ID: 20120419052828.30885.69011 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On April 15, 2012, 10:26 p.m., Albert Astals Cid wrote:
> > To be honest i'm not sure i like the antialiased variants more, but on the other \
> > hand, i'm not a user of kig so not sure you should be listening to me :D
I actually have no preference over one or the other. Maybe add a configuration \
checkbox to use antialiasing?
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104584/#review12491
-----------------------------------------------------------
On April 15, 2012, 5:26 p.m., David Narváez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104584/
> -----------------------------------------------------------
>
> (Updated April 15, 2012, 5:26 p.m.)
>
>
> Review request for KDE Edu.
>
>
> Description
> -------
>
> Pretty straightforward, the question is actually if anybody disagrees. The one \
> issue I would be concerned about is performance, but I would expect this not to be \
> an issue in modern computers, yet I don't have any stress case to test this \
> against.
>
> This addresses bug 122376.
> http://bugs.kde.org/show_bug.cgi?id=122376
>
>
> Diffs
> -----
>
> misc/kigpainter.cpp 18d4396
>
> Diff: http://git.reviewboard.kde.org/r/104584/diff/
>
>
> Testing
> -------
>
> Compare drawing a large circle with and without this patch to see antialiasing in \
> action.
>
> Screenshots
> -----------
>
> Antialiased
> http://git.reviewboard.kde.org/r/104584/s/535/
> Aliased
> http://git.reviewboard.kde.org/r/104584/s/536/
> Antialiased Heptagonal Tessellation
> http://git.reviewboard.kde.org/r/104584/s/539/
> Aliased Heptagonal Tessellation
> http://git.reviewboard.kde.org/r/104584/s/540/
>
>
> Thanks,
>
> David Narváez
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104584/">http://git.reviewboard.kde.org/r/104584/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 15th, 2012, 10:26 p.m., <b>Albert Astals \
Cid</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">To be honest i'm not sure i like the antialiased variants more, but \
on the other hand, i'm not a user of kig so not sure you should be listening to \
me :D</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I actually have no \
preference over one or the other. Maybe add a configuration checkbox to use \
antialiasing?</pre> <br />
<p>- David</p>
<br />
<p>On April 15th, 2012, 5:26 p.m., David Narváez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Edu.</div>
<div>By David Narváez.</div>
<p style="color: grey;"><i>Updated April 15, 2012, 5:26 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Pretty straightforward, the question is actually if anybody disagrees. \
The one issue I would be concerned about is performance, but I would expect this not \
to be an issue in modern computers, yet I don't have any stress case to test this \
against.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compare drawing a large circle with and without this patch to see \
antialiasing in action.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=122376">122376</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>misc/kigpainter.cpp <span style="color: grey">(18d4396)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104584/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/104584/s/535/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/04/15/kig-arcsandlines-antialiased_400x100.png" \
style="border: 1px black solid;" alt="Antialiased" /></a>
<a href="http://git.reviewboard.kde.org/r/104584/s/536/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/04/15/kig-arcsandlines-aliased_400x100.png" \
style="border: 1px black solid;" alt="Aliased" /></a>
<a href="http://git.reviewboard.kde.org/r/104584/s/539/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/04/15/kig-heptagonaltessellation-antialiased_400x100.png" \
style="border: 1px black solid;" alt="Antialiased Heptagonal Tessellation" /></a>
<a href="http://git.reviewboard.kde.org/r/104584/s/540/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/04/15/kig-heptagonaltessellation-aliased_1_400x100.png" \
style="border: 1px black solid;" alt="Aliased Heptagonal Tessellation" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic