'Re: Review Request: KBruch - Bug 192707'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-edu
Subject:    Re: Review Request: KBruch - Bug 192707
From:       "Luis Angel Fernandez Fernandez" <laffdez () gmail ! com>
Date:       2011-09-19 11:18:05
Message-ID: 20110919111805.27089.72768 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102582/
-----------------------------------------------------------

(Updated Sept. 19, 2011, 11:18 a.m.)

Review request for KDE Edu.

Changes
-------

Now the user can only append new factors (or remove them using backspace key).

Summary
-------

This is my first contribution so, please, tell me if I did anything wrong. This patch \
is intended to solve this bug https://bugs.kde.org/show_bug.cgi?id=192707 in KBruch. \
After applying this patch (I hope I extracted it rightly) the direct editing is \
working.

As I said this is my first submitting so, please, don't hesitate to ask me anything \
you want/need about this patch.

This addresses bug 192707.
    http://bugs.kde.org/show_bug.cgi?id=192707

Diffs (updated)
-----

  src/PrimeFactorsLineEdit.h 5e78082 
  src/PrimeFactorsLineEdit.cpp b71bfba 
  src/exercisefactorize.h c7d304f 
  src/exercisefactorize.cpp 48c8874 

Diff: http://git.reviewboard.kde.org/r/102582/diff

Testing
-------

Thanks,

Luis Angel

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102582/">http://git.reviewboard.kde.org/r/102582/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Edu.</div>
<div>By Luis Angel Fernandez Fernandez.</div>

<p style="color: grey;"><i>Updated Sept. 19, 2011, 11:18 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Now the user can only append new factors (or remove them using backspace \
key).</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is my first contribution so, please, tell me if I did anything \
wrong. This patch is intended to solve this bug \
https://bugs.kde.org/show_bug.cgi?id=192707 in KBruch. After applying this patch (I \
hope I extracted it rightly) the direct editing is working.

As I said this is my first submitting so, please, don&#39;t hesitate to ask me \
anything you want/need about this patch.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=192707">192707</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>src/PrimeFactorsLineEdit.h <span style="color: grey">(5e78082)</span></li>

 <li>src/PrimeFactorsLineEdit.cpp <span style="color: grey">(b71bfba)</span></li>

 <li>src/exercisefactorize.h <span style="color: grey">(c7d304f)</span></li>

 <li>src/exercisefactorize.cpp <span style="color: grey">(48c8874)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102582/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu

[prev in list] [next in list] [prev in thread] [next in thread] 