[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu
Subject: [kde-edu]: Review Request: Parley: [PATCH] Added dictation practice.
From: "Massimo Lo Iacono" <massimol () lillinet ! org>
Date: 2011-02-15 23:53:18
Message-ID: 20110215235318.32209.18442 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6489/
-----------------------------------------------------------
Review request for KDE-Edu.
Summary
-------
Hallo.
I have made the modifications to add functionality for dictation practice.
Dictation is a monolanguage type of practice. It consists a sound (only) qu=
estion and a text solution in the same language of question.
The language of practice is the first of the pair languageFrom/languageTo.
For developers:
Since the dictation practice is of the type monolanguage and the pre existe=
nt code was for bilanguage practice, I modified a bit the code in order tha=
t now it is adapt also for a monolanguage type of practice.
I added these new 4 files in "src/4/kdeedu/parley/src/practice/" directory:
dictationbackendmode.h
dictationbackendmode.cpp
dictationmodewidget.h
dictationmodewidget.cpp
I can send these file as attachments in the parley develop mailing list.
IMPORTANT: to manage the visualisation of question and solution images, I w=
as forced to create the new function:
GuiFrontend::compareImage()
and to modify the functions:
AbstractBackendMode::setTestEntry
MultipleChoiceBackendMode::setTestEntry
ConjugationBackendMode::setTestEntry
ComparisonBackendMode::setTestEntry
=
adding the rows:
m_frontend->setQuestionImage
m_frontend->setSolutionImage
m_frontend->compareImage();
I created the patch from the 1218525 revision, almost 2 weeks old.
I can successful compile and execute the code with my modifications.
Diffs
-----
/trunk/KDE/kdeedu/CMakeLists.txt 1218525 =
/trunk/KDE/kdeedu/parley/src/CMakeLists.txt 1218525 =
/trunk/KDE/kdeedu/parley/src/practice/abstractbackendmode.cpp 1218525 =
/trunk/KDE/kdeedu/parley/src/practice/abstractfrontend.h 1218525 =
/trunk/KDE/kdeedu/parley/src/practice/comparisonbackendmode.cpp 1218525 =
/trunk/KDE/kdeedu/parley/src/practice/conjugationbackendmode.cpp 1218525 =
/trunk/KDE/kdeedu/parley/src/practice/guifrontend.h 1218525 =
/trunk/KDE/kdeedu/parley/src/practice/guifrontend.cpp 1218525 =
/trunk/KDE/kdeedu/parley/src/practice/multiplechoicebackendmode.cpp 12185=
25 =
/trunk/KDE/kdeedu/parley/src/practice/practiceoptions.cpp 1218525 =
/trunk/KDE/kdeedu/parley/src/practice/practicestatemachine.cpp 1218525 =
/trunk/KDE/kdeedu/parley/src/practice/practicesummarycomponent.cpp 121852=
5 =
/trunk/KDE/kdeedu/parley/src/practice/writtenpracticewidget.h 1218525 =
/trunk/KDE/kdeedu/parley/src/practice/writtenpracticewidget.cpp 1218525 =
/trunk/KDE/kdeedu/parley/src/settings/parley.kcfg 1218525 =
/trunk/KDE/kdeedu/parley/src/statistics/statisticsmainwindow.cpp 1218525 =
/trunk/KDE/kdeedu/parley/src/statistics/statisticsmainwindow.ui 1218525 =
Diff: http://svn.reviewboard.kde.org/r/6489/diff
Testing
-------
I can successful compile and execute the code with my modifications.
Thanks,
Massimo
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6489/">http://svn.reviewboard.kde.org/r/6489/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE-Edu.</div>
<div>By Massimo Lo Iacono.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hallo. I have made the modifications to add functionality for dictation \
practice.
Dictation is a monolanguage type of practice. It consists a sound (only) question and \
a text solution in the same language of question.
The language of practice is the first of the pair languageFrom/languageTo.
For developers:
Since the dictation practice is of the type monolanguage and the pre existent code \
was for bilanguage practice, I modified a bit the code in order that now it is adapt \
also for a monolanguage type of practice.
I added these new 4 files in "src/4/kdeedu/parley/src/practice/" directory:
dictationbackendmode.h
dictationbackendmode.cpp
dictationmodewidget.h
dictationmodewidget.cpp
I can send these file as attachments in the parley develop mailing list.
IMPORTANT: to manage the visualisation of question and solution images, I was forced \
to create the new function:
GuiFrontend::compareImage()
and to modify the functions:
AbstractBackendMode::setTestEntry
MultipleChoiceBackendMode::setTestEntry
ConjugationBackendMode::setTestEntry
ComparisonBackendMode::setTestEntry
adding the rows:
m_frontend->setQuestionImage
m_frontend->setSolutionImage
m_frontend->compareImage();
I created the patch from the 1218525 revision, almost 2 weeks old.
I can successful compile and execute the code with my modifications.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I can successful compile and execute the code with my \
modifications.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdeedu/CMakeLists.txt <span style="color: grey">(1218525)</span></li>
<li>/trunk/KDE/kdeedu/parley/src/CMakeLists.txt <span style="color: \
grey">(1218525)</span></li>
<li>/trunk/KDE/kdeedu/parley/src/practice/abstractbackendmode.cpp <span \
style="color: grey">(1218525)</span></li>
<li>/trunk/KDE/kdeedu/parley/src/practice/abstractfrontend.h <span style="color: \
grey">(1218525)</span></li>
<li>/trunk/KDE/kdeedu/parley/src/practice/comparisonbackendmode.cpp <span \
style="color: grey">(1218525)</span></li>
<li>/trunk/KDE/kdeedu/parley/src/practice/conjugationbackendmode.cpp <span \
style="color: grey">(1218525)</span></li>
<li>/trunk/KDE/kdeedu/parley/src/practice/guifrontend.h <span style="color: \
grey">(1218525)</span></li>
<li>/trunk/KDE/kdeedu/parley/src/practice/guifrontend.cpp <span style="color: \
grey">(1218525)</span></li>
<li>/trunk/KDE/kdeedu/parley/src/practice/multiplechoicebackendmode.cpp <span \
style="color: grey">(1218525)</span></li>
<li>/trunk/KDE/kdeedu/parley/src/practice/practiceoptions.cpp <span style="color: \
grey">(1218525)</span></li>
<li>/trunk/KDE/kdeedu/parley/src/practice/practicestatemachine.cpp <span \
style="color: grey">(1218525)</span></li>
<li>/trunk/KDE/kdeedu/parley/src/practice/practicesummarycomponent.cpp <span \
style="color: grey">(1218525)</span></li>
<li>/trunk/KDE/kdeedu/parley/src/practice/writtenpracticewidget.h <span \
style="color: grey">(1218525)</span></li>
<li>/trunk/KDE/kdeedu/parley/src/practice/writtenpracticewidget.cpp <span \
style="color: grey">(1218525)</span></li>
<li>/trunk/KDE/kdeedu/parley/src/settings/parley.kcfg <span style="color: \
grey">(1218525)</span></li>
<li>/trunk/KDE/kdeedu/parley/src/statistics/statisticsmainwindow.cpp <span \
style="color: grey">(1218525)</span></li>
<li>/trunk/KDE/kdeedu/parley/src/statistics/statisticsmainwindow.ui <span \
style="color: grey">(1218525)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6489/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic