From kde-edu  Tue Feb 23 15:51:57 2010
From: "Daniel Laidig" <d.laidig () gmx ! de>
Date: Tue, 23 Feb 2010 15:51:57 +0000
To: kde-edu
Subject: Re: [kde-edu]: Review Request: [Parley-branch] Display as many
Message-Id: <20100223155157.15029.68245 () localhost>
X-MARC-Message: https://marc.info/?l=kde-edu&m=126695006417874



> On 2010-02-22 22:12:55, Daniel Laidig wrote:
> > You should delete the old widgets before creating new ones. I think adding  "qDeleteAll(m_choiceButtons);" before "m_choiceButtons = QList<QRadioButton*>();" should do the trick.
> > 
> > Currently it doesn't matter because the number doesn't change and the widgets are only created once.
> 
> Carlos Licea wrote:
>     May I sugest m_choiceButtons.clear() instead of the assignment?
> 
> Nicolas Réau wrote:
>     Actually, that has been also the suggestion of tsdgeos on IRC :).
>     I could replace 
>     qDeleteAll(m_choiceButtons);
>     m_choiceButtons = QList<QRadioButton*>();
>     by 
>     m_choiceButtons.clear(); ?

No, just instead of "m_choiceButtons = QList<QRadioButton*>();". The qDeleteAll needs to stay.


- Daniel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2852/#review4248
-----------------------------------------------------------


On 2010-02-21 18:17:47, Nicolas Réau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2852/
> -----------------------------------------------------------
> 
> (Updated 2010-02-21 18:17:47)
> 
> 
> Review request for KDE-Edu and Frederik Gladhorn.
> 
> 
> Summary
> -------
> 
> The radio buttons in multiple choice mode are now displayed according to the option set by the user in the config dialog (instead of being hardcoded to 5 choices).
> 
> 
> Diffs
> -----
> 
>   branches/work/parley-practice/parley/src/practice/multiplechoicemodewidget.h 1093868 
>   branches/work/parley-practice/parley/src/practice/multiplechoicemodewidget.cpp 1093868 
>   branches/work/parley-practice/parley/src/practice/practice_widget_multiplechoice.ui 1093868 
> 
> Diff: http://reviewboard.kde.org/r/2852/diff
> 
> 
> Testing
> -------
> 
> It works fine here. However I'm not satisfied of my code: I feel like I'm touching some files i shouldn't have too.
> 
> Please review it and tell if it's bad implemented or how it can be improved. (btw I've not removed my debug messages from the diff yet).
> 
> 
> Thanks,
> 
> Nicolas
> 
>

_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu