[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-doc-english
Subject: Re: Review Request 128745: Update skanlite docbook to kf5
From: Kåre Särs <kare.sars () iki ! fi>
Date: 2016-08-24 12:38:02
Message-ID: 20160824123802.4407.28566 () mimi ! kde ! org
[Download RAW message or body]
--===============1415570755426973896==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128745/#review98593
-----------------------------------------------------------
Ship it!
You rock again :)
I'll add the images
- Kåre Särs
On Aug. 24, 2016, 12:27 p.m., Burkhard Lück wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128745/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2016, 12:27 p.m.)
>
>
> Review request for Documentation and Kåre Särs.
>
>
> Repository: skanlite
>
>
> Description
> -------
>
> proofread + update
> update screenshots except choose-scanner.png (only 1 scanner) + other-options.png \
> (Scanner Specific Options tab empty here) remove entities skanlite, package, \
> kappname - either unused any more or already defined in kdoctools flat scanners -> \
> image scanners as in appdata.xml KDE -> &Qt;
> <guibutton>Close</guibutton> -> <guibutton>Discard</guibutton>
> remove appendix
>
> @ Kåre: please add the two missing screenshots
>
>
> Diffs
> -----
>
> doc/buttons-main.png 979b3df
> doc/final-button.png a77bf5a
> doc/index.docbook 8d24f33
> doc/main-window.png b7d0c85
> doc/multiple-selections.png 77f1afa
> doc/no-scanner-found.png f73ac54
> doc/preview-button.png b2fb441
> doc/preview.png b2295f9
> doc/save-location.png 7e1f020
> doc/scanning.png 7ba33a1
> doc/settings.png f2edbd3
> doc/zoom-in.png b24eaf0
> doc/zoom-to-fit.png 572967c
>
> Diff: https://git.reviewboard.kde.org/r/128745/diff/
>
>
> Testing
> -------
>
> passes checkXML5
>
>
> File Attachments
> ----------------
>
> buttons-main.png
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/24/a586dc43-0b21-4c1f-a3b9-98b5176a41cb__buttons-main.png
> final-button.png
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/24/56773639-5790-4b3d-bda6-9887dca8bcdf__final-button.png
> main-window.png
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/24/ecb63e92-fb33-451d-ad4c-fee2a02da6d6__main-window.png
> multiple-selections.png
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/24/31f35c96-417b-4cd6-beb3-ba9594bb4874__multiple-selections.png
> no-scanner-found.png
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/24/f0add7df-ec09-4c78-9011-07d892d6dfff__no-scanner-found.png
> preview-button.png
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/24/0e43acd1-b418-49e0-9377-d030a9b3d1b5__preview-button.png
> preview.png
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/24/dd641a94-6ce9-4950-8df3-4dbe490a6507__preview.png
> save-location.png
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/24/c9f9e37b-795d-4a71-bd05-75b8d8391b49__save-location.png
> scanning.png
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/24/d1f2a669-228b-41a2-8ef4-75def6abb41c__scanning.png
> settings.png
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/24/74040737-fd09-4e65-84d4-1d6774096689__settings.png
> zoom-in.png
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/24/73918521-a281-4ecc-9fca-da8ec273ab98__zoom-in.png
> zoom-to-fit.png
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/24/9be2cfbf-0e28-470c-9747-41a69ec8f499__zoom-to-fit.png
>
>
> Thanks,
>
> Burkhard Lück
>
>
--===============1415570755426973896==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128745/">https://git.reviewboard.kde.org/r/128745/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You rock again :)
I'll add the images</pre>
<br />
<p>- Kåre Särs</p>
<br />
<p>On August 24th, 2016, 12:27 p.m. UTC, Burkhard Lück wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Documentation and Kåre Särs.</div>
<div>By Burkhard Lück.</div>
<p style="color: grey;"><i>Updated Aug. 24, 2016, 12:27 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
skanlite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">proofread + update update screenshots except choose-scanner.png (only 1 \
scanner) + other-options.png (Scanner Specific Options tab empty here) remove \
entities skanlite, package, kappname - either unused any more or already defined in \
kdoctools flat scanners -> image scanners as in appdata.xml
KDE -> &Qt;
<guibutton>Close</guibutton> -> \
<guibutton>Discard</guibutton> remove appendix
@ Kåre: please add the two missing screenshots</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">passes checkXML5</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>doc/buttons-main.png <span style="color: grey">(979b3df)</span></li>
<li>doc/final-button.png <span style="color: grey">(a77bf5a)</span></li>
<li>doc/index.docbook <span style="color: grey">(8d24f33)</span></li>
<li>doc/main-window.png <span style="color: grey">(b7d0c85)</span></li>
<li>doc/multiple-selections.png <span style="color: grey">(77f1afa)</span></li>
<li>doc/no-scanner-found.png <span style="color: grey">(f73ac54)</span></li>
<li>doc/preview-button.png <span style="color: grey">(b2fb441)</span></li>
<li>doc/preview.png <span style="color: grey">(b2295f9)</span></li>
<li>doc/save-location.png <span style="color: grey">(7e1f020)</span></li>
<li>doc/scanning.png <span style="color: grey">(7ba33a1)</span></li>
<li>doc/settings.png <span style="color: grey">(f2edbd3)</span></li>
<li>doc/zoom-in.png <span style="color: grey">(b24eaf0)</span></li>
<li>doc/zoom-to-fit.png <span style="color: grey">(572967c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128745/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/08/24/a586dc43-0b21-4c1f-a3b9-98b5176a41cb__buttons-main.png">buttons-main.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/08/24/56773639-5790-4b3d-bda6-9887dca8bcdf__final-button.png">final-button.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/08/24/ecb63e92-fb33-451d-ad4c-fee2a02da6d6__main-window.png">main-window.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/08/24/31f35c96 \
-417b-4cd6-beb3-ba9594bb4874__multiple-selections.png">multiple-selections.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/08/24/f0add7df \
-ec09-4c78-9011-07d892d6dfff__no-scanner-found.png">no-scanner-found.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/08/24/0e43acd1-b418-49e0-9377-d030a9b3d1b5__preview-button.png">preview-button.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/08/24/dd641a94-6ce9-4950-8df3-4dbe490a6507__preview.png">preview.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/08/24/c9f9e37b-795d-4a71-bd05-75b8d8391b49__save-location.png">save-location.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/08/24/d1f2a669-228b-41a2-8ef4-75def6abb41c__scanning.png">scanning.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/08/24/74040737-fd09-4e65-84d4-1d6774096689__settings.png">settings.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/08/24/73918521-a281-4ecc-9fca-da8ec273ab98__zoom-in.png">zoom-in.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/08/24/9be2cfbf-0e28-470c-9747-41a69ec8f499__zoom-to-fit.png">zoom-to-fit.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1415570755426973896==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic