[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-doc-english
Subject: Re: [kde-doc-english] Review Request 122080: More up-to-date image for web pages
From: "Allen Winter" <winter () kde ! org>
Date: 2015-01-16 17:29:18
Message-ID: 20150116172918.19346.92489 () probe ! kde ! org
[Download RAW message or body]
--===============9024515400640434892==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122080/#review74150
-----------------------------------------------------------
Ship it!
looks good. I'm indifferent about giving a new name. although kde_logo is really not correct now, so yes \
a new name makes some sense.
- Allen Winter
On Jan. 15, 2015, 10:33 p.m., Luigi Toscano wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122080/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2015, 10:33 p.m.)
>
>
> Review request for Documentation, Albert Astals Cid, Jarosław Staniek, and Allen Winter.
>
>
> Bugs: 342710
> https://bugs.kde.org/show_bug.cgi?id=342710
>
>
> Repository: kdoctools
>
>
> Description
> -------
>
> "Part of KDE family" logo from https://www.kde.org/stuff/clipart.php,
>
>
> The change needs to be backported to kdelibs4 as well.
>
> Other files that should be fixed:
> kf5: frameworks/kdoctools/src/customization/kde-web-navig.xsl
> kde/kdelibs/kdoctools/customization/kde-web-navig.xsl
>
> info kioslave:
> kdelibs4: kde/kde-runtime/kioslave/info/kde-info2html
> kf5: kde/workspace/kio-extras/info/kde-info2html
>
> Open questions:
> - Is it LGPL licensed? It seems so, as derived work from the official logo.
>
> - No other users of kde_logo.png and kde_logo_bn.png are recorded.
> http://lxr.kde.org/search?_filestring=&_string=kde_logo
> On the other side, they have been provided by kdelibs4 and kdoctools, so maybe we should consider them \
> as API and not remove them.
>
> Diffs
> -----
>
> common/en/part_of_the_kde_family_horizontal_190.png PRE-CREATION
> src/customization/kde-web-navig.xsl 3892d96
>
> Diff: https://git.reviewboard.kde.org/r/122080/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Luigi Toscano
>
>
--===============9024515400640434892==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122080/">https://git.reviewboard.kde.org/r/122080/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">looks good. I'm indifferent about giving a new name. although kde_logo is \
really not correct now, so yes a new name makes some sense.</p></pre> <br />
<p>- Allen Winter</p>
<br />
<p>On January 15th, 2015, 10:33 p.m. UTC, Luigi Toscano wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Documentation, Albert Astals Cid, Jarosław Staniek, and Allen Winter.</div>
<div>By Luigi Toscano.</div>
<p style="color: grey;"><i>Updated Jan. 15, 2015, 10:33 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=342710">342710</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdoctools
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">"Part of KDE family" logo from \
https://www.kde.org/stuff/clipart.php,</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">The change needs to be backported to kdelibs4 as well.</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Other \
files that should be fixed:
kf5: frameworks/kdoctools/src/customization/kde-web-navig.xsl
kde/kdelibs/kdoctools/customization/kde-web-navig.xsl</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">info \
kioslave:
kdelibs4: kde/kde-runtime/kioslave/info/kde-info2html
kf5: kde/workspace/kio-extras/info/kde-info2html</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Open \
questions:
- Is it LGPL licensed? It seems so, as derived work from the official logo.</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: \
normal;"> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">No other users of kde_logo.png and kde_logo_bn.png are recorded. \
http://lxr.kde.org/search?_filestring=&_string=kde_logo On the other side, they have been provided by \
kdelibs4 and kdoctools, so maybe we should consider them as API and not remove them.</li> </ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>common/en/part_of_the_kde_family_horizontal_190.png <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/customization/kde-web-navig.xsl <span style="color: grey">(3892d96)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122080/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============9024515400640434892==--
_______________________________________________
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic