'Re: [kde-doc-english] Review Request 119589: Allow KHelpCenter from Plasma 5 to work with KDE4 appli'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-doc-english
Subject:    Re: [kde-doc-english] Review Request 119589: Allow KHelpCenter from Plasma 5 to work with KDE4 appli
From:       "Scarlett Clark" <sgclark () kubuntu ! org>
Date:       2014-10-21 20:52:25
Message-ID: 20141021205225.18179.5545 () probe ! kde ! org
[Download RAW message or body]

--===============1799656656771379411==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

> On Oct. 21, 2014, 1:47 p.m., Luigi Toscano wrote:
> > Uhm, I think the patch can go in. It's not breaking existing stuff and there are \
> > no conflicts with existing files.

just an FYI I had to adjust this patch to line 92 for it to apply.

- Scarlett

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119589/#review68851
-----------------------------------------------------------

On Aug. 3, 2014, 9:59 a.m., Matthew Dawson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119589/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2014, 9:59 a.m.)
> 
> 
> Review request for Documentation and Plasma.
> 
> 
> Repository: khelpcenter
> 
> 
> Description
> -------
> 
> KHelpCenter 5.0.0 works with handbooks from KDE4 applications, but by
> default they cannot launch it.  Fix that so KDE4 applications don't lose
> their help when someone upgrades to Plasma 5.
> 
> 
> Diffs
> -----
> 
> CMakeLists.txt 728b2583c052fd09e85ef66aa3e99d092948837d 
> 
> Diff: https://git.reviewboard.kde.org/r/119589/diff/
> 
> 
> Testing
> -------
> 
> Tested installing a manual patch against my system install.  Hitting F1 in dolphin \
> launches KHelpCenter as expected, with the dolphin help displayed (after running \
> kbuildsyscoca4). 
> 
> Thanks,
> 
> Matthew Dawson
> 
> 

--===============1799656656771379411==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119589/">https://git.reviewboard.kde.org/r/119589/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On October 21st, 2014, 1:47 p.m. PDT, <b>Luigi \
Toscano</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Uhm, I think the patch can go in. It's not breaking \
existing stuff and there are no conflicts with existing files.</p></pre>  \
</blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">just \
an FYI I had to adjust this patch to line 92 for it to apply.</p></pre> <br />

<p>- Scarlett</p>

<br />
<p>On August 3rd, 2014, 9:59 a.m. PDT, Matthew Dawson wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Documentation and Plasma.</div>
<div>By Matthew Dawson.</div>

<p style="color: grey;"><i>Updated Aug. 3, 2014, 9:59 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
khelpcenter
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">KHelpCenter 5.0.0 works with handbooks from KDE4 \
applications, but by default they cannot launch it.  Fix that so KDE4 applications \
don't lose their help when someone upgrades to Plasma 5.</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested installing a manual patch against my system \
install.  Hitting F1 in dolphin launches KHelpCenter as expected, with the dolphin \
help displayed (after running kbuildsyscoca4).</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: \
grey">(728b2583c052fd09e85ef66aa3e99d092948837d)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119589/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1799656656771379411==--

_______________________________________________
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

[prev in list] [next in list] [prev in thread] [next in thread] 