'[kde-doc-english] Review Request 120210: kdoctools: style images more elegantly'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-doc-english
Subject:    [kde-doc-english] Review Request 120210: kdoctools: style images more elegantly
From:       "T.C. Hollingsworth" <tchollingsworth () gmail ! com>
Date:       2014-09-15 4:44:07
Message-ID: 20140915044407.22585.17785 () probe ! kde ! org
[Download RAW message or body]

--===============2025660589020544564==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120210/
-----------------------------------------------------------

Review request for Documentation, kdelibs and Luigi Toscano.

Repository: kdelibs

Description
-------

The ugly <hr> elements that used to surround DocBook <mediaobject> elements are \
removed, and replaced with CSS styling around <screenshot> and <informalfigure> \
elements only.  Plain <mediaobject> elements are now unstyled.  
As discussed on the documentation team mailing list:
http://lists.kde.org/?l=kde-doc-english&m=141019053410846&w=2

Filed originally against KDE/4.14 at the request of Luigi Toscano, will forward port \
to KF5/kdoctools also.

Diffs
-----

  doc/common/kde-default.css 24ef928 
  doc/common/kde-docs.css db23b3e 
  kdoctools/customization/kde-style.xsl 03e8bc9 

Diff: https://git.reviewboard.kde.org/r/120210/diff/

Testing
-------

Rerun meinproc4 against documentation; verified new style in konqueror and \
khelpcenter.

Thanks,

T.C. Hollingsworth

--===============2025660589020544564==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/120210/">https://git.reviewboard.kde.org/r/120210/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Documentation, kdelibs and Luigi Toscano.</div>
<div>By T.C. Hollingsworth.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The ugly &lt;hr&gt; elements that used to surround \
DocBook &lt;mediaobject&gt; elements are removed, and replaced with CSS styling \
around &lt;screenshot&gt; and &lt;informalfigure&gt; elements only.  Plain \
&lt;mediaobject&gt; elements are now unstyled.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As \
discussed on the documentation team mailing list:<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> \
http://lists.kde.org/?l=kde-doc-english&amp;m=141019053410846&amp;w=2</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Filed originally against KDE/4.14 at the request of Luigi Toscano, will \
forward port to KF5/kdoctools also.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Rerun meinproc4 against documentation; verified new \
style in konqueror and khelpcenter.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>doc/common/kde-default.css <span style="color: grey">(24ef928)</span></li>

 <li>doc/common/kde-docs.css <span style="color: grey">(db23b3e)</span></li>

 <li>kdoctools/customization/kde-style.xsl <span style="color: \
grey">(03e8bc9)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/120210/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============2025660589020544564==--

_______________________________________________
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english

[prev in list] [next in list] [prev in thread] [next in thread] 