[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 117985: frameworks/kjs: add missing man page docbook
From: "Kevin Ottens" <ervin () kde ! org>
Date: 2014-06-17 16:07:03
Message-ID: 20140617160703.3733.33287 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On May 5, 2014, 7:17 a.m., Kevin Ottens wrote:
> > IIRC that was intentional as to not have kjs depend on kdoctools.
>
> Alex Merry wrote:
> Hrm. Distros like Debian aren't going to be super-happy about this. And KJS is \
> officially a porting aid, so I'm not sure bumping it to tier 3 is that big of an \
> issue (especially since the practical dependencies are still minimal).
OK, makes sense then. This patch should update the metainfo.yaml though.
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117985/#review57287
-----------------------------------------------------------
On May 4, 2014, 7:21 a.m., Burkhard Lück wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117985/
> -----------------------------------------------------------
>
> (Updated May 4, 2014, 7:21 a.m.)
>
>
> Review request for Documentation and KDE Frameworks.
>
>
> Repository: kjs
>
>
> Description
> -------
>
> add missing man page docbook, which got lost in the transition from kdelibs to \
> frameworks
>
> Diffs
> -----
>
> CMakeLists.txt 60ee824
> docs/CMakeLists.txt PRE-CREATION
> docs/kjs/CMakeLists.txt PRE-CREATION
> docs/kjs/man-kjs5.1.docbook PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/117985/diff/
>
>
> Testing
> -------
>
> build + installed, viewed with "man kjs5"
>
>
> Thanks,
>
> Burkhard Lück
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117985/">https://git.reviewboard.kde.org/r/117985/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On May 5th, 2014, 7:17 a.m. UTC, <b>Kevin \
Ottens</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">IIRC that was intentional as to not have kjs depend on kdoctools.</pre> \
</blockquote>
<p>On May 29th, 2014, 11:11 a.m. UTC, <b>Alex Merry</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hrm. Distros like Debian \
aren't going to be super-happy about this. And KJS is officially a porting aid, \
so I'm not sure bumping it to tier 3 is that big of an issue (especially since \
the practical dependencies are still minimal).</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">OK, makes sense then. \
This patch should update the metainfo.yaml though.</pre> <br />
<p>- Kevin</p>
<br />
<p>On May 4th, 2014, 7:21 a.m. UTC, Burkhard Lück wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Documentation and KDE Frameworks.</div>
<div>By Burkhard Lück.</div>
<p style="color: grey;"><i>Updated May 4, 2014, 7:21 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kjs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">add missing man page docbook, which got lost in the transition from \
kdelibs to frameworks</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">build + installed, viewed with "man kjs5"</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(60ee824)</span></li>
<li>docs/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>docs/kjs/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>docs/kjs/man-kjs5.1.docbook <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117985/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic