From kde-doc-english Sat Feb 22 17:41:53 2014 From: "Alex Merry" Date: Sat, 22 Feb 2014 17:41:53 +0000 To: kde-doc-english Subject: Re: [kde-doc-english] Review Request 115876: More generic DocBookXML -> DocBookXML4 Message-Id: <20140222174153.24989.43413 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-doc-english&m=139309095016473 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1799118875400494126==" --===============1799118875400494126== Content-Type: multipart/alternative; boundary="===============0704147288571556382==" --===============0704147288571556382== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On Feb. 21, 2014, 7:47 p.m., Luigi Toscano wrote: > > The files have been moved to kdoctools, should I open a new review against the kdoctools component or can I get a shipit here? :) I thought I'd already made this reply, but let's try again... (maybe I did it on another RR?) I would rather this was combined with https://git.reviewboard.kde.org/r/115879/ as a single commit/review in kdoctools. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115876/#review50488 ----------------------------------------------------------- On Feb. 18, 2014, 10:52 p.m., Luigi Toscano wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115876/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2014, 10:52 p.m.) > > > Review request for Build System, Documentation and KDE Frameworks. > > > Repository: extra-cmake-modules > > > Description > ------- > > FindDocBookXML.cmake was originally part of kdelibs/kdoctools, but not installed. The version currently in ECM is, as the old one, is quite tight to the old behavior, it hardcodes the DocBookXML version currently used. > - the rename reflect the fact that it's used for DocBookXML4; a future DocBookXML5 could be added if needed; > - the structure allows a generic usage ("find DocBookXML version 4.x"), not tied to the usage in KDocTools. KDocTools will be changed to call it with the correct version (the version number is a "property" of KDocTools, not used outside it, but hidden inside meinproc5 and libKF5XsltKde.a). > Next changes: > - use DocBookXML4 (so DocBookXML4_* instead of DOCBOOKXML_* legacy variables) in frameworks > - move the definition of legacy DOCBOOKXML_* in kde4support > > > Diffs > ----- > > find-modules/FindDocBookXML.cmake b6d623e > find-modules/FindDocBookXML4.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/115876/diff/ > > > Testing > ------- > > Compiles (some changes are needed in KDocTools, I will add them to another review). > > > Thanks, > > Luigi Toscano > > --===============0704147288571556382== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115876/

On February 21st, 2014, 7:47 p.m. UTC, Luigi Toscano wrote:
The files have been moved to kdoctools, should I open a new review against the kdoctools component or can I get a shipit here? :)

I thought I'd already made this reply, but let's try again... (maybe I did it on another RR?)

I would rather this was combined with https://git.reviewboard.kde.org/r/115879/ as a single commit/review in kdoctools.

- Alex

On February 18th, 2014, 10:52 p.m. UTC, Luigi Toscano wrote:

Review request for Build System, Documentation and KDE Frameworks.

By Luigi Toscano.

Updated Feb. 18, 2014, 10:52 p.m.

Repository: extra-cmake-modules

Description

FindDocBookXML.cmake was originally part of kdelibs/kdoctools, but not installed. The version currently in ECM is, as the old one, is quite tight to the old behavior, it hardcodes the DocBookXML version currently used.
- the rename reflect the fact that it's used for DocBookXML4; a future DocBookXML5 could be added if needed;
- the structure allows a generic usage ("find DocBookXML version 4.x"), not tied to the usage in KDocTools. KDocTools will be changed to call it with the correct version (the version number is a "property" of KDocTools, not used outside it, but hidden inside meinproc5 and libKF5XsltKde.a).
Next changes: 
- use DocBookXML4 (so DocBookXML4_* instead of DOCBOOKXML_* legacy variables) in frameworks
- move the definition of legacy DOCBOOKXML_* in kde4support

Testing

Compiles (some changes are needed in KDocTools, I will add them to another review).

Diffs

find-modules/FindDocBookXML.cmake (b6d623e)
find-modules/FindDocBookXML4.cmake (PRE-CREATION)

--===============0704147288571556382==-- --===============1799118875400494126== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kde-doc-english mailing list kde-doc-english@kde.org https://mail.kde.org/mailman/listinfo/kde-doc-english --===============1799118875400494126==--