'Re: Review Request 115896: Import FindDocBook*.cmake from extra-cmake-modules'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 115896: Import FindDocBook*.cmake from extra-cmake-modules
From:       "Alex Merry" <kde () randomguy3 ! me ! uk>
Date:       2014-02-21 11:21:02
Message-ID: 20140221112102.27041.39394 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115896/
-----------------------------------------------------------

(Updated Feb. 21, 2014, 11:21 a.m.)

Status
------

This change has been marked as submitted.

Review request for Documentation, KDE Frameworks and Luigi Toscano.

Repository: kdoctools

Description
-------

Commits imported with `git format-patch` (edited), followed by `git am`.

Add the local cmake directory to the CMake module path

Use the newer syntax in FindDocBook*

It approprietly sets the _FOUND variables, we were defining the all
uppercase instead.
Sorry for the mess!

Originally commit 190c79bb4e6bc8b8757bd890485a9bafb4a65219 of the
extra-cmake-modules repository

Move FindDocBook* to find-modules

Originally commit d42d5889d25ac4c900a294f283dd802eccf96010 of the
extra-cmake-modules repository

Diffs
-----

  CMakeLists.txt d135e0caa55d126ba3c335b9f05f8125453c1e53 
  cmake/FindDocBookXML.cmake PRE-CREATION 
  cmake/FindDocBookXSL.cmake PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/115896/diff/

Testing
-------

Removed FindDocBook*.cmake from $PREFIX/share/ECM/find-modules, and a clean configure, build, install still works.

Thanks,

Alex Merry

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115896/">https://git.reviewboard.kde.org/r/115896/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
 <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for Documentation, KDE Frameworks and Luigi Toscano.</div>
<div>By Alex Merry.</div>

<p style="color: grey;"><i>Updated Feb. 21, 2014, 11:21 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdoctools
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Commits imported with \
`git format-patch` (edited), followed by `git am`.

Add the local cmake directory to the CMake module path

Use the newer syntax in FindDocBook*

It approprietly sets the _FOUND variables, we were defining the all
uppercase instead.
Sorry for the mess!

Originally commit 190c79bb4e6bc8b8757bd890485a9bafb4a65219 of the
extra-cmake-modules repository

Move FindDocBook* to find-modules

Originally commit d42d5889d25ac4c900a294f283dd802eccf96010 of the
extra-cmake-modules repository</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Removed \
FindDocBook*.cmake from $PREFIX/share/ECM/find-modules, and a clean configure, build, install \
still works.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: \
grey">(d135e0caa55d126ba3c335b9f05f8125453c1e53)</span></li>

 <li>cmake/FindDocBookXML.cmake <span style="color: grey">(PRE-CREATION)</span></li>

 <li>cmake/FindDocBookXSL.cmake <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115896/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 