[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-doc-english
Subject: Re: [kde-doc-english] Review Request 111851: Split KCModules into different Categories in KHelpcente
From: Burkhard_Lück <lueck () hube-lueck ! de>
Date: 2013-12-10 19:00:00
Message-ID: 20131210190000.30263.52160 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Nov. 29, 2013, 7:32 p.m., Ben Cooksley wrote:
> > Patch looks fine to me, sucks a bit that the names have to be hardcoded for \
> > certain lists but not much can be done there if that is what the applications \
> > do...
"Patch looks fine to me" = "Ship It!" ?
- Burkhard
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111851/#review44837
-----------------------------------------------------------
On Nov. 29, 2013, 12:37 p.m., Burkhard Lück wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111851/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2013, 12:37 p.m.)
>
>
> Review request for Documentation, KDE Runtime, Albert Astals Cid, Ben Cooksley, \
> David Faure, and Frank Reininghaus.
>
> Bugs: 262935
> http://bugs.kde.org/show_bug.cgi?id=262935
>
>
> Repository: kde-runtime
>
>
> Description
> -------
>
> The KHelpcenter navigation tree has a top level item "Control Center Modules",
> an unsorted list of all KCModules (>80 for a full kde main modules install from \
> stable). This makes this item hardly usable, see \
> https://bugs.kde.org/show_bug.cgi?id=262935
> This patch implements:
>
> A) Alphabetical sorting for "Control Center Modules"/"Foo Settings Modules" + \
> "KInfoCenter" items
> B) New / changed top level categories in the navigation tree:
>
> 1) System Settings Modules -> replaces old "Control Center Modules"
> items: see http://docs.kde.org/stable/en/kde-workspace/systemsettings/general.html
>
> 2) Konqueror Settings Modules (see Konqueror settings dialog)
> items: General, Performance, Bookmarks
>
> 3) Filemanager Settings Modules (see Konqueror/Dolphin settings dialog)
> items:
> File Management, View Modes, Navigation, Services, General, Trash
> No File Associations, because it is already in System Settings Modules
>
> 4) Browser Settings Modules (see Konqueror settings dialog)
> items:
> Web Browsing, Proxy, Appearance, AdBlocK Filters, Web Shortcuts, Cache,
> History, Cookies, Browser Identification, Java & JavaScript, Plugins
>
> 5) Other Settings Modules
> all other items like e.g. CGI Scripts from kde-runtime
>
> To make full use of these new/changed categories some kcm desktop files in other
> modules than kde-runtime need a change of X-KDE-ParentApp from kcontrol to \
> konquerorcontrol, browsercontrol, filemanagercontrol or othercontrol, but that is \
> not part of this review. As long as not all desktop files are fixed according to \
> this patch or a necessary change in a desktop files is overlooked that KCM will be \
> in System Settings Modules like now, but in sorted order.
> C) Change wording from "Control Center Modules" to "System Settings Modules" and \
> using "Foo Settings Modules" for the new categories.
> Control Center is from KDE 3, we use System Settings nearly all over GUI and in the \
> whole documentation.
>
> Diffs
> -----
>
> khelpcenter/navigator.cpp 7460cc8
> khelpcenter/plugins/CMakeLists.txt d09b869
> khelpcenter/plugins/browsercontrolmodules.desktop PRE-CREATION
> khelpcenter/plugins/filemanagercontrolmodules.desktop PRE-CREATION
> khelpcenter/plugins/kcontrolmodules.desktop 1813df3
> khelpcenter/plugins/konquerorcontrolmodules.desktop PRE-CREATION
> khelpcenter/plugins/othercontrolmodules.desktop PRE-CREATION
> khelpcenter/plugintraverser.cpp b0b0e78
>
> Diff: http://git.reviewboard.kde.org/r/111851/diff/
>
>
> Testing
> -------
>
> Checked with one example each for konquerorcontrol, browsercontrol, \
> filemanagercontrol and othercontrol, see attached screenshot.
>
>
> File Attachments
> ----------------
>
> New Categories in KHelpcenter navigation tree
> http://git.reviewboard.kde.org/media/uploaded/files/2013/08/03/khelpcenter1.png
>
>
> Thanks,
>
> Burkhard Lück
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111851/">http://git.reviewboard.kde.org/r/111851/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 29th, 2013, 7:32 p.m. UTC, <b>Ben \
Cooksley</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Patch looks fine to me, sucks a bit that the names have to be hardcoded \
for certain lists but not much can be done there if that is what the applications \
do...</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"Patch looks fine \
to me" = "Ship It!" ?</pre> <br />
<p>- Burkhard</p>
<br />
<p>On November 29th, 2013, 12:37 p.m. UTC, Burkhard Lück wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Documentation, KDE Runtime, Albert Astals Cid, Ben Cooksley, \
David Faure, and Frank Reininghaus.</div> <div>By Burkhard Lück.</div>
<p style="color: grey;"><i>Updated Nov. 29, 2013, 12:37 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=262935">262935</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-runtime
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The KHelpcenter navigation tree has a top level item "Control \
Center Modules", an unsorted list of all KCModules (>80 for a full kde main \
modules install from stable). This makes this item hardly usable, see \
https://bugs.kde.org/show_bug.cgi?id=262935
This patch implements:
A) Alphabetical sorting for "Control Center Modules"/"Foo Settings \
Modules" + "KInfoCenter" items
B) New / changed top level categories in the navigation tree:
1) System Settings Modules -> replaces old "Control Center Modules"
items: see http://docs.kde.org/stable/en/kde-workspace/systemsettings/general.html
2) Konqueror Settings Modules (see Konqueror settings dialog)
items: General, Performance, Bookmarks
3) Filemanager Settings Modules (see Konqueror/Dolphin settings dialog)
items:
File Management, View Modes, Navigation, Services, General, Trash
No File Associations, because it is already in System Settings Modules
4) Browser Settings Modules (see Konqueror settings dialog)
items:
Web Browsing, Proxy, Appearance, AdBlocK Filters, Web Shortcuts, Cache,
History, Cookies, Browser Identification, Java & JavaScript, Plugins
5) Other Settings Modules
all other items like e.g. CGI Scripts from kde-runtime
To make full use of these new/changed categories some kcm desktop files in other
modules than kde-runtime need a change of X-KDE-ParentApp from kcontrol to \
konquerorcontrol, browsercontrol, filemanagercontrol or othercontrol, but that is \
not part of this review. As long as not all desktop files are fixed according to \
this patch or a necessary change in a desktop files is overlooked that KCM will be \
in System Settings Modules like now, but in sorted order.
C) Change wording from "Control Center Modules" to "System Settings \
Modules" and using "Foo Settings Modules" for the new categories.
Control Center is from KDE 3, we use System Settings nearly all over GUI and in \
the whole documentation. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Checked with one example each for konquerorcontrol, browsercontrol, \
filemanagercontrol and othercontrol, see attached screenshot.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>khelpcenter/navigator.cpp <span style="color: grey">(7460cc8)</span></li>
<li>khelpcenter/plugins/CMakeLists.txt <span style="color: \
grey">(d09b869)</span></li>
<li>khelpcenter/plugins/browsercontrolmodules.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>khelpcenter/plugins/filemanagercontrolmodules.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>khelpcenter/plugins/kcontrolmodules.desktop <span style="color: \
grey">(1813df3)</span></li>
<li>khelpcenter/plugins/konquerorcontrolmodules.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>khelpcenter/plugins/othercontrolmodules.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>khelpcenter/plugintraverser.cpp <span style="color: grey">(b0b0e78)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111851/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/08/03/khelpcenter1.png">New \
Categories in KHelpcenter navigation tree</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic