[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-doc-english
Subject:    Re: [kde-doc-english] Review Request 111248: Documentation: Rework of menus.docbook Phase One. EBN F
From:       "Laurent Montel" <montel () kde ! org>
Date:       2013-06-27 10:25:28
Message-ID: 20130627102528.3658.42902 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


> On June 26, 2013, 4:27 p.m., Burkhard Lück wrote:
> > doc/kmail/menus.docbook, lines 165-170
> > <http://git.reviewboard.kde.org/r/111248/diff/3/?file=165911#file165911line165>
> > 
> > /me has this item in recent master
> 
> Scarlett Clark wrote:
> Not on mine built by kdesrc-build. Clearly not working then, I have tried to figure \
> out how to properly have a dev build with no success. sigh. 
> Laurent Montel wrote:
> There is this menu entry. But if you don't have it it's that you can create print \
> preview. There is a check if you can do it. If you don't able it will not show.
> So for me you must keep it.
> 
> Scarlett Clark wrote:
> Where do I find the check to enable or disable print preview?

in messageactions.cpp:

  if(KPrintPreview::isAvailable())
    mPrintPreviewAction = KStandardAction::printPreview( this, \
SLOT(slotPrintPreviewMsg()), ac );


- Laurent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111248/#review35128
-----------------------------------------------------------


On June 26, 2013, 6:34 p.m., Scarlett Clark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111248/
> -----------------------------------------------------------
> 
> (Updated June 26, 2013, 6:34 p.m.)
> 
> 
> Review request for Documentation, KDEPIM and Laurent Montel.
> 
> 
> Description
> -------
> 
> Reworking menus.docbook to match current menus. I am rewriting one section at a \
> time due to size of this endeavor. EBN fixes apply to entire document. 
> 
> Diffs
> -----
> 
> doc/kmail/menus.docbook e8298c4 
> 
> Diff: http://git.reviewboard.kde.org/r/111248/diff/
> 
> 
> Testing
> -------
> 
> checkXML index.docbook (after every change!) meinproc4 index.docbook, konqueror \
> index.docbook. EBN. 
> 
> Thanks,
> 
> Scarlett Clark
> 
> 


[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/111248/">http://git.reviewboard.kde.org/r/111248/</a>
  </td>
    </tr>
   </table>
   <br />










<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On June 26th, 2013, 4:27 p.m. UTC, <b>Burkhard \
Lück</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/111248/diff/3/?file=165911#file165911line165" \
style="color: black; font-weight: bold; text-decoration: \
underline;">doc/kmail/menus.docbook</a>  <span style="font-weight: normal;">

     (Diff revision 3)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">111</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">&lt;!-- \
Missing from menu   6/25/13 sgclark</pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">112</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">&lt;varlistentry&gt;&lt;term&gt;&lt;menuchoice&gt;&lt;guimenu&gt;File&lt;/guimenu&gt;&lt;guimenuitem&gt;Print \
Preview...&lt;/guimenuitem&gt;&lt;/menuchoice&gt;&lt;/term&gt;</pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">113</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">&lt;listitem&gt;</pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">114</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">&lt;para&gt;&lt;action&gt;Display a dialog which shows how your email will be \
printed.&lt;/action&gt;&lt;/para&gt;</pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">115</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">&lt;/listitem&gt;</pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">116</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">&lt;/varlistentry&gt; --&gt;</pre></td>  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">/me has this item in \
recent master</pre>  </blockquote>



 <p>On June 26th, 2013, 4:56 p.m. UTC, <b>Scarlett Clark</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not on mine built by \
kdesrc-build. Clearly not working then, I have tried to figure out how to properly \
have a dev build with no success. sigh.</pre>  </blockquote>





 <p>On June 27th, 2013, 8:04 a.m. UTC, <b>Laurent Montel</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There is this menu \
entry. But if you don&#39;t have it it&#39;s that you can create print preview. There \
is a check if you can do it. If you don&#39;t able it will not show. So for me you \
must keep it.</pre>  </blockquote>





 <p>On June 27th, 2013, 10:03 a.m. UTC, <b>Scarlett Clark</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Where do I find the \
check to enable or disable print preview?</pre>  </blockquote>







</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">in \
messageactions.cpp:

  if(KPrintPreview::isAvailable())
    mPrintPreviewAction = KStandardAction::printPreview( this, \
SLOT(slotPrintPreviewMsg()), ac ); </pre>
<br />




<p>- Laurent</p>


<br />
<p>On June 26th, 2013, 6:34 p.m. UTC, Scarlett Clark wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Documentation, KDEPIM and Laurent Montel.</div>
<div>By Scarlett Clark.</div>


<p style="color: grey;"><i>Updated June 26, 2013, 6:34 p.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Reworking menus.docbook to match current menus. I am rewriting one \
section at a time due to size of this endeavor. EBN fixes apply to entire \
document.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">checkXML index.docbook (after every change!) meinproc4 index.docbook, \
konqueror index.docbook. EBN.</pre>  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>doc/kmail/menus.docbook <span style="color: grey">(e8298c4)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/111248/diff/" style="margin-left: \
3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>



_______________________________________________
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic