[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-doc-english
Subject:    Re: [kde-doc-english] <gui...> markup in title elements
From:       "Yuri Chornoivan" <yurchor () ukr ! net>
Date:       2013-05-06 18:48:35
Message-ID: op.wwoei9fil2zvei () localhost
[Download RAW message or body]

=D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BD=D0=B5 Mon, 06 May 2013 21:05:=
34 +0300, Albert Astals Cid  =

<aacid@kde.org>:

> El Dilluns, 6 de maig de 2013, a les 20:43:27, Yuri Chornoivan va  =

> escriure:
>> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BD=D0=B5 Mon, 06 May 2013 19:=
43:37 +0300, Burkhard L=C3=BCck
>>
>> <lueck@hube-lueck.de>:
>> > Hi,
>> >
>> > the kde docbooks often have <gui...> markup in title elements of a
>> > section.
>> >
>> > This lead to the following issues, illustrated with the KMahJongg
>> > handbook:
>> >
>> > 1) First page - Table of Content
>> > Some word with a grey background due to <gui...> markup in a title.=

>> > For me it looks strange and confusing (why some words and some not?=
)  =

>> and
>> > to
>> > mark some words as gui element does not make sense in the table of
>> > content
>> >
>> > 2) E. g. the Page "The Move Menu"
>> > In the page header "Move" has a grey background due to <gui...> mar=
kup
>> > in the
>> > title element of an sect1. That looks really ugly.
>> >
>> > Title elements of a section already have a different font than the
>> > normal text,
>> > so you can distinguish title + text easily.
>> >
>> > I'd like to get rid of the gui markup in title elements, what do yo=
u
>> > think?
>>
>> Hi,
>>
>> I completely agree that guimenu and guilabel make titles look ugly an=
d
>> should be avoided/removed.
>
> Maybe we should "just" improve the CSS?
>
> I mean does guimenu/guilabel make sense from the content point of view=
  =

> and is
> looks the only problem?
>
> Cheers,
>   Albert

Attached is an untested patch against kdelibs to fix the guiitem style i=
n  =

titles.

Many thanks for testing.

Best regards,
Yuri
["testgui.patch" (testgui.patch)]

diff --git a/kdoctools/customization/kde-style.xsl b/kdoctools/customization/kde-style.xsl
index 03e8bc9..bb835ac 100644
--- a/kdoctools/customization/kde-style.xsl
+++ b/kdoctools/customization/kde-style.xsl
@@ -5,9 +5,14 @@
 <xsl:param name="callout.graphics.path" select="'common/'" doc:type='string'/>
 
 <xsl:template match="guilabel|guimenu|guisubmenu|guimenuitem|interface|guibutton">
-  <span class="guiitem">
-     <xsl:call-template name="inline.charseq"/>
-  </span>
+  <xsl:when test="ancestor::title">
+    <xsl:call-template name="inline.charseq"/>
+  </xsl:when>
+  <xsl:otherwise>
+    <span class="guiitem">
+      <xsl:call-template name="inline.charseq"/>
+    </span>
+  </xsl:otherwise>
 </xsl:template>
 
 <xsl:template match="accel">


_______________________________________________
kde-doc-english mailing list
kde-doc-english@kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english


[prev in list] [next in list] [prev in thread] [next in thread]