From kde-devel  Mon Jul 30 22:45:14 2001
From: Juerg Marti <tschortsch () gmx ! ch>
Date: Mon, 30 Jul 2001 22:45:14 +0000
To: kde-devel
Subject: Re: kppp miniterm patch & questions
X-MARC-Message: https://marc.info/?l=kde-devel&m=99653331126558
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--------------Boundary-00=_EV5BFJY7EHJMP0DG9RH4"


--------------Boundary-00=_EV5BFJY7EHJMP0DG9RH4
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 8bit

On Monday 30 July 2001 12:30, Harri Porten wrote:
> Going for KMainWindow (probably also non-existant at that time) would be
> nice. Can you send me a patch ? :)
Here is the patch :)
But don't apply it, there is a problem with it. The QTabDialog tabWindow is 
modal. Then MiniTerm is showed from that dialog. Now the MiniTerm is blocked. 
I guess it's impossible to create and show  a modalless dialog from a modal 
dialog.

> > 5) Is it really necessary to delete toolbar and statusbar in the
> > destructor? They are children of MiniTerm, so they should be deleted by
> > qt.
>
> Yes. Traces of people learning how to program C++ and Qt ... ;)

No it's not necessary. (at least in my version, but it was in the original 
one)
I've done:
toolbar=new KMenuBar(this)
statusbar=new QLabel(this)
so the toolbar is a childwidget of MiniTerm.
so the toolbar's parent (=MiniTerm) will delete the toolbar .


--------------Boundary-00=_EV5BFJY7EHJMP0DG9RH4
Content-Type: text/x-diff;
  charset="iso-8859-1";
  name="miniterm.diff"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="miniterm.diff"

PyBtaW5pdGVybS5kaWZmCkluZGV4OiBnZW5lcmFsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAv
aG9tZS9rZGUva2RlbmV0d29yay9rcHBwL2dlbmVyYWwuY3BwLHYKcmV0cmlldmluZyByZXZpc2lv
biAxLjc0CmRpZmYgLXUgLTMgLXAgLXUgLXIxLjc0IGdlbmVyYWwuY3BwCi0tLSBnZW5lcmFsLmNw
cAkyMDAxLzA0LzA4IDIxOjIzOjA1CTEuNzQKKysrIGdlbmVyYWwuY3BwCTIwMDEvMDcvMzAgMjE6
NTU6MjgKQEAgLTU4Miw4ICs1ODIsOCBAQCB2b2lkIE1vZGVtV2lkZ2V0Mjo6cXVlcnlfbW9kZW0o
KSB7CiAKIAogdm9pZCBNb2RlbVdpZGdldDI6OnRlcm1pbmFsKCkgewotICBNaW5pVGVybSB0ZXJt
aW5hbChOVUxMLE5VTEwpOwotICB0ZXJtaW5hbC5leGVjKCk7CisgIE1pbmlUZXJtICp0ZXJtaW5h
bD1uZXcgTWluaVRlcm0oTlVMTCxOVUxMKTsKKyAgdGVybWluYWwtPnNob3coKTsKIH0KIAogCklu
ZGV4OiBtaW5pdGVybS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2hvbWUva2RlL2tkZW5ldHdv
cmsva3BwcC9taW5pdGVybS5jcHAsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMzUKZGlmZiAtdSAt
MyAtcCAtdSAtcjEuMzUgbWluaXRlcm0uY3BwCi0tLSBtaW5pdGVybS5jcHAJMjAwMS8wNy8zMCAx
MDoyNToyMQkxLjM1CisrKyBtaW5pdGVybS5jcHAJMjAwMS8wNy8zMCAyMTo1NToyOQpAQCAtMzgs
MjAgKzM4LDIwIEBACiAjaW5jbHVkZSA8a2dsb2JhbC5oPgogI2luY2x1ZGUgPGtwb3B1cG1lbnUu
aD4KIAorCiBleHRlcm4gUFBQRGF0YSBncHBwZGF0YTsKIAogTWluaVRlcm06Ok1pbmlUZXJtKFFX
aWRnZXQgKnBhcmVudCwgY29uc3QgY2hhciAqbmFtZSkKLSAgOiBRRGlhbG9nKHBhcmVudCwgbmFt
ZSwgdHJ1ZSkKKyAgOiBLTWFpbldpbmRvdyhwYXJlbnQsIG5hbWUpCiB7CiAgIHNldENhcHRpb24o
aTE4bigiS3BwcCBNaW5pLVRlcm1pbmFsIikpOwogICBLV2luOjpzZXRJY29ucyh3aW5JZCgpLCBr
YXBwLT5pY29uKCksIGthcHAtPm1pbmlJY29uKCkpOwogCi0gIG1fZmlsZSA9IG5ldyBRUG9wdXBN
ZW51KHRoaXMpOworICBtX2ZpbGUgPSBuZXcgS1BvcHVwTWVudSh0aGlzKTsKICAgbV9maWxlLT5p
bnNlcnRJdGVtKCBpMThuKCImQ2xvc2UiKSx0aGlzLCBTTE9UKGNhbmNlbGJ1dHRvbigpKSApOwot
ICBtX29wdGlvbnMgPSBuZXcgUVBvcHVwTWVudSh0aGlzKTsKKyAgbV9vcHRpb25zID0gbmV3IEtQ
b3B1cE1lbnUodGhpcyk7CiAgIG1fb3B0aW9ucy0+aW5zZXJ0SXRlbShpMThuKCImUmVzZXQgTW9k
ZW0iKSx0aGlzLFNMT1QocmVzZXRNb2RlbSgpKSk7Ci0gIG1faGVscCA9Ci0gICAgbmV3IEtIZWxw
TWVudSh0aGlzLAorICBtX2hlbHAgPSBoZWxwTWVudSgKIAkJICAgICAgaTE4bigiTWluaVRlcm0g
LSBBIHRlcm1pbmFsIGVtdWxhdGlvbiBmb3IgS1BQUFxuXG4iCiAJCQkgICAiKGMpIDE5OTcgQmVy
bmQgSm9oYW5uZXMgV3VlYmJlbiA8d3VlYmJlbkBrZGUub3JnPlxuIgogCQkJICAgIihjKSAxOTk4
IEhhcnJpIFBvcnRlbiA8cG9ydGVuQGtkZS5vcmc+XG4iCkBAIC02MCwyMyArNjAsMTYgQEAgTWlu
aVRlcm06Ok1pbmlUZXJtKFFXaWRnZXQgKnBhcmVudCwgY29ucwogCQkJICAgIihHTlUgR2VuZXJh
bCBQdWJsaWMgTGljZW5zZSkiCiAJCQkgICApKTsKIAotICBtZW51YmFyID0gbmV3IEtNZW51QmFy
KHRoaXMpOworICBtZW51YmFyID0gbWVudUJhcigpOwogICBtZW51YmFyLT5pbnNlcnRJdGVtKCBp
MThuKCImRmlsZSIpLCBtX2ZpbGUgKTsKICAgbWVudWJhci0+aW5zZXJ0SXRlbSggaTE4bigiJk1v
ZGVtIiksIG1fb3B0aW9ucyApOwotICBtZW51YmFyLT5pbnNlcnRJdGVtKCBpMThuKCImSGVscCIp
LCBtX2hlbHAtPm1lbnUoKSk7Ci0KLSAgc3RhdHVzYmFyID0gbmV3IFFMYWJlbCh0aGlzKTsKLSAg
c3RhdHVzYmFyLT5zZXRGcmFtZVN0eWxlKFFGcmFtZTo6UGFuZWwgfCBRRnJhbWU6OlN1bmtlbik7
CisgIG1lbnViYXItPmluc2VydEl0ZW0oIGkxOG4oIiZIZWxwIiksIG1faGVscCk7CiAKKyAgc3Rh
dHVzYmFyID0gc3RhdHVzQmFyKCk7CiAgIHRlcm1pbmFsID0gbmV3IE15VGVybSh0aGlzLCAidGVy
bSIpOwogCiAgIHNldHVwVG9vbGJhcigpOwotCi0gIFFWQm94TGF5b3V0ICpsYXlvdXQ9bmV3IFFW
Qm94TGF5b3V0KHRoaXMpOwotICBsYXlvdXQtPmFkZFdpZGdldChtZW51YmFyKTsKLSAgbGF5b3V0
LT5hZGRXaWRnZXQodG9vbGJhcik7Ci0gIGxheW91dC0+YWRkV2lkZ2V0KHRlcm1pbmFsKTsKLSAg
bGF5b3V0LT5hZGRXaWRnZXQoc3RhdHVzYmFyKTsKKyAgc2V0Q2VudHJhbFdpZGdldCh0ZXJtaW5h
bCk7CiAKICAgaW5pdHRpbWVyID0gbmV3IFFUaW1lcih0aGlzKTsKICAgY29ubmVjdChpbml0dGlt
ZXIsU0lHTkFMKHRpbWVvdXQoKSksdGhpcyxTTE9UKGluaXQoKSkpOwpAQCAtODYsMTQgKzc5LDgg
QEAgTWluaVRlcm06Ok1pbmlUZXJtKFFXaWRnZXQgKnBhcmVudCwgY29ucwogfQogCiAKLU1pbmlU
ZXJtOjp+TWluaVRlcm0oKSB7Ci0gIGRlbGV0ZSB0b29sYmFyOwotICBkZWxldGUgc3RhdHVzYmFy
OwotfQotCi0KIHZvaWQgTWluaVRlcm06OnNldHVwVG9vbGJhcigpIHsKLSAgdG9vbGJhciA9IG5l
dyBLVG9vbEJhciggdGhpcyApOworICB0b29sYmFyID0gdG9vbEJhcigpOwogCiAgIFFQaXhtYXAg
cGl4bWFwOwogCkBAIC0xMjAsMTcgKzEwNywxNyBAQCB2b2lkIE1pbmlUZXJtOjpzZXR1cFRvb2xi
YXIoKSB7CiAKIHZvaWQgTWluaVRlcm06OmluaXQoKSB7CiAgIGluaXR0aW1lci0+c3RvcCgpOwot
ICBzdGF0dXNiYXItPnNldFRleHQoaTE4bigiSW5pdGlhbGl6aW5nIE1vZGVtIikpOworICBzdGF0
dXNiYXItPmluc2VydEl0ZW0oaTE4bigiSW5pdGlhbGl6aW5nIE1vZGVtIiksMCwxKTsKICAga2Fw
cC0+cHJvY2Vzc0V2ZW50cygpOwogCiAgIGludCBsb2NrID0gTW9kZW06Om1vZGVtLT5sb2NrZGV2
aWNlKCk7CiAgIGlmIChsb2NrID09IDEpIHsKLSAgICBzdGF0dXNiYXItPnNldFRleHQoaTE4bigi
U29ycnksIG1vZGVtIGRldmljZSBpcyBsb2NrZWQuIikpOworICAgIHN0YXR1c2Jhci0+Y2hhbmdl
SXRlbShpMThuKCJTb3JyeSwgbW9kZW0gZGV2aWNlIGlzIGxvY2tlZC4iKSwwKTsKICAgICByZXR1
cm47CiAgIH0KIAogICBpZiAobG9jayA9PSAtMSkgewotICAgIHN0YXR1c2Jhci0+c2V0VGV4dChp
MThuKCJTb3JyeSwgY2FuJ3QgY3JlYXRlIG1vZGVtIGxvY2sgZmlsZS4iKSk7CisgICAgc3RhdHVz
YmFyLT5jaGFuZ2VJdGVtKGkxOG4oIlNvcnJ5LCBjYW4ndCBjcmVhdGUgbW9kZW0gbG9jayBmaWxl
LiIpLDApOwogICAgIHJldHVybjsKICAgfQogCkBAIC0xNDYsNyArMTMzLDcgQEAgdm9pZCBNaW5p
VGVybTo6aW5pdCgpIHsKICAgICBNb2RlbTo6bW9kZW0tPndyaXRlTGluZShncHBwZGF0YS5tb2Rl
bUluaXRTdHIoKS5sb2NhbDhCaXQoKSk7CiAgICAgdXNsZWVwKGdwcHBkYXRhLm1vZGVtSW5pdERl
bGF5KCkgKiAxMDAwMCk7CiAKLSAgICAgIHN0YXR1c2Jhci0+c2V0VGV4dChpMThuKCJNb2RlbSBS
ZWFkeSIpKTsKKyAgICAgIHN0YXR1c2Jhci0+Y2hhbmdlSXRlbShpMThuKCJNb2RlbSBSZWFkeSIp
LDApOwogICAgICAgdGVybWluYWwtPnNldEZvY3VzKCk7CiAKICAgICAgIGthcHAtPnByb2Nlc3NF
dmVudHMoKTsKQEAgLTE1OCw3ICsxNDUsNyBAQCB2b2lkIE1pbmlUZXJtOjppbml0KCkgewogICB9
CiAKICAgLy8gb3BlbnR0eSgpIG9yIGhhbmd1cCgpIGZhaWxlZAotICBzdGF0dXNiYXItPnNldFRl
eHQoTW9kZW06Om1vZGVtLT5tb2RlbU1lc3NhZ2UoKSk7CisgIHN0YXR1c2Jhci0+Y2hhbmdlSXRl
bShNb2RlbTo6bW9kZW0tPm1vZGVtTWVzc2FnZSgpLDApOwogICBNb2RlbTo6bW9kZW0tPnVubG9j
a2RldmljZSgpOwogfQogCkBAIC0xODcsNyArMTc0LDcgQEAgdm9pZCBNaW5pVGVybTo6cmVhZENo
YXIodW5zaWduZWQgY2hhciBjKQogdm9pZCBNaW5pVGVybTo6Y2FuY2VsYnV0dG9uKCkgewogICBN
b2RlbTo6bW9kZW0tPnN0b3AoKTsKIAotICBzdGF0dXNiYXItPnNldFRleHQoaTE4bigiSGFuZ2lu
ZyB1cCAuLi4iKSk7CisgIHN0YXR1c2Jhci0+Y2hhbmdlSXRlbShpMThuKCJIYW5naW5nIHVwIC4u
LiIpLDApOwogICBrYXBwLT5wcm9jZXNzRXZlbnRzKCk7CiAgIGthcHAtPmZsdXNoWCgpOwogCkBA
IC0xOTYsMTkgKzE4MywxOSBAQCB2b2lkIE1pbmlUZXJtOjpjYW5jZWxidXR0b24oKSB7CiAgIE1v
ZGVtOjptb2RlbS0+Y2xvc2V0dHkoKTsKICAgTW9kZW06Om1vZGVtLT51bmxvY2tkZXZpY2UoKTsK
IAotICByZWplY3QoKTsKKyAgY2xvc2UoKTsKIH0KIAogCiB2b2lkIE1pbmlUZXJtOjpyZXNldE1v
ZGVtKCkgewotICBzdGF0dXNiYXItPnNldFRleHQoaTE4bigiUmVzZXR0aW5nIE1vZGVtIikpOwor
ICBzdGF0dXNiYXItPmNoYW5nZUl0ZW0oaTE4bigiUmVzZXR0aW5nIE1vZGVtIiksMCk7CiAgIHRl
cm1pbmFsLT5uZXdMaW5lKCk7CiAgIGthcHAtPnByb2Nlc3NFdmVudHMoKTsKICAga2FwcC0+Zmx1
c2hYKCk7CiAKICAgTW9kZW06Om1vZGVtLT5oYW5ndXAoKTsKIAotICBzdGF0dXNiYXItPnNldFRl
eHQoaTE4bigiTW9kZW0gUmVhZHkiKSk7CisgIHN0YXR1c2Jhci0+Y2hhbmdlSXRlbShpMThuKCJN
b2RlbSBSZWFkeSIpLDApOwogfQogCiAKSW5kZXg6IG1pbml0ZXJtLmgKPT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1Mg
ZmlsZTogL2hvbWUva2RlL2tkZW5ldHdvcmsva3BwcC9taW5pdGVybS5oLHYKcmV0cmlldmluZyBy
ZXZpc2lvbiAxLjEzCmRpZmYgLXUgLTMgLXAgLXUgLXIxLjEzIG1pbml0ZXJtLmgKLS0tIG1pbml0
ZXJtLmgJMjAwMS8wNy8zMCAxMDoyNTo0MQkxLjEzCisrKyBtaW5pdGVybS5oCTIwMDEvMDcvMzAg
MjE6NTU6MjkKQEAgLTI4LDExICsyOCw5IEBACiAjaWZuZGVmIF9NSU5JVEVSTV9IXwogI2RlZmlu
ZSBfTUlOSVRFUk1fSF8KIAotI2luY2x1ZGUgPHFkaWFsb2cuaD4KICNpbmNsdWRlIDxxcGl4bWFw
Lmg+CiAjaW5jbHVkZSA8cWxheW91dC5oPgogI2luY2x1ZGUgPHFwb3B1cG1lbnUuaD4KLSNpbmNs
dWRlIDxxbGFiZWwuaD4KICNpbmNsdWRlIDxxZXZlbnQuaD4KICNpbmNsdWRlIDxxdGltZXIuaD4K
ICNpbmNsdWRlIDxxZnJhbWUuaD4KQEAgLTQxLDcgKzM5LDkgQEAKIAogI2luY2x1ZGUgPGt0b29s
YmFyLmg+CiAjaW5jbHVkZSA8a21lbnViYXIuaD4KKyNpbmNsdWRlIDxrbWFpbndpbmRvdy5oPgog
Y2xhc3MgS0hlbHBNZW51OworY2xhc3MgS1N0YXR1c0JhcjsKIAogY2xhc3MgTXlUZXJtIDogcHVi
bGljIFFNdWx0aUxpbmVFZGl0IHsKICAgUV9PQkpFQ1QKQEAgLTU4LDEyICs1OCwxMiBAQCBwdWJs
aWM6CiB9OwogCiAKLWNsYXNzIE1pbmlUZXJtIDogcHVibGljIFFEaWFsb2cgeworY2xhc3MgTWlu
aVRlcm0gOiBwdWJsaWMgS01haW5XaW5kb3cgewogICBRX09CSkVDVAogcHVibGljOgogCiAgIE1p
bmlUZXJtKFFXaWRnZXQgKnBhcmVudD0wLCBjb25zdCBjaGFyICpuYW1lPTApOwotICB+TWluaVRl
cm0oKTsKKyAgfk1pbmlUZXJtKCl7fTsKIAogICB2b2lkIGNsb3NlRXZlbnQoIFFDbG9zZUV2ZW50
ICplICk7CiAKQEAgLTc3LDI2ICs3NywxNiBAQCBwdWJsaWMgc2xvdHM6CiBwcm90ZWN0ZWQ6CiAg
IHZvaWQgc2V0dXBUb29sYmFyKCk7CiAKLSAgUVB1c2hCdXR0b24gKmNhbmNlbDsKICAgTXlUZXJt
ICp0ZXJtaW5hbDsKICAgUVRpbWVyICppbml0dGltZXI7CiAKLSAgUU1lbnVCYXIgICAgKiBtZW51
YmFyOworICBLTWVudUJhciAgICAqIG1lbnViYXI7CiAgIEtUb29sQmFyICAgICAqIHRvb2xiYXI7
Ci0gIFFQb3B1cE1lbnUgICogbV9maWxlOwotICBRUG9wdXBNZW51ICAqIG1fZWRpdDsKLSAgUVBv
cHVwTWVudSAgKiBtX29wdGlvbnM7Ci0gIEtIZWxwTWVudSAgKiBtX2hlbHA7Ci0gIFFMYWJlbCAg
ICAgICogc3RhdHVzYmFyOwotICBRUHVzaEJ1dHRvbiAqcGIxOwotICBRUHVzaEJ1dHRvbiAqcGIy
OwotICBRUHVzaEJ1dHRvbiAqcGIzOwotICBRUHVzaEJ1dHRvbiAqcGI0OwotCi0gIFFQaXhtYXAg
cGIxX3BpeG1hcDsKLSAgUVBpeG1hcCBwYjJfcGl4bWFwOwotICBRUGl4bWFwIHBiM19waXhtYXA7
Ci0gIFFQaXhtYXAgcGI0X3BpeG1hcDsKKyAgS1BvcHVwTWVudSAgKiBtX2ZpbGU7CisgIEtQb3B1
cE1lbnUgICogbV9lZGl0OworICBLUG9wdXBNZW51ICAqIG1fb3B0aW9uczsKKyAgS1BvcHVwTWVu
dSAgKiBtX2hlbHA7CisgIEtTdGF0dXNCYXIgICogc3RhdHVzYmFyOwogfTsKIAogCg==

--------------Boundary-00=_EV5BFJY7EHJMP0DG9RH4--
 
>> Visit http://master.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<