[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: kppp miniterm patch & questions
From:       Harri Porten <porten () trolltech ! com>
Date:       2001-07-30 10:30:00
[Download RAW message or body]

On Sun, 29 Jul 2001, Juerg Marti wrote:

> The layout managment of kppp's miniterm is broken. I replaced the setGeomtry 
> stuff in miniterm.cpp with a QVBoxLayout and the QMenuBar with a KMenuBar. 
> The patch for this is attached.

Applied to CVS. Thanks.

> But I have still some questions:
> 1) There is a problem with the dialogs in the helpmenu of miniterm. When I 
> open one of them (i.e. Help->About KPPP) I'm not able to close it. Maybe this 
> is because MiniTerm is a modal Dialog. Any ideas?

This dialog's behaviour really turned akward after the underlying libs
(and window managers) changed over the years.

> 2) I don't understand why a QLabel is used for the statusbar.

Probably because there was no [QK]StatusBar when this dialog was written.

> 3) Why is there a second QLabel statusbar2, which is never used? 

Don't know what the plan was with that one. Removed it completely.

> 4) I think It's strange to put a MenuBar, a ToolBar and a StatusBar in a 
> Dialog. Maybe MiniTerm should inherit KMainWindow and not QDialog or we 
> should remove the StatusBar and the MenuBar.

Going for KMainWindow (probably also non-existant at that time) would be
nice. Can you send me a patch ? :)

> 5) Is it really necessary to delete toolbar and statusbar in the destructor? 
> They are children of MiniTerm, so they should be deleted by qt.

Yes. Traces of people learning how to program C++ and Qt ... ;)

Harri.

 
>> Visit http://master.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]