[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    [PATCH] Re: Solaris 2.6 - Pb to compile kdelibs/kdesu
From:       Rob Napier <rnapier () employees ! org>
Date:       2001-06-28 16:34:57
[Download RAW message or body]

On Thu, Jun 28, 2001 at 05:39:49PM +0200, Julien Gilles wrote:
> Rob Napier <rnapier@employees.org> writes:
> 
> > On Tue, Jun 26, 2001 at 02:15:39PM +0200, Dirk Mueller wrote:
> > > On Die, 26 Jun 2001, Julien Gilles wrote:
> > > 
> > > > 
> > > > #if (!defined(_POSIX_C_SOURCE) && !defined(_XOPEN_SOURCE)) || \
> > > > 	defined(_XPG4_2) || defined(__EXTENSIONS__)
> > > > 
> > > > It seems to me that the condition is false, lstat is then not defined and
> > > > the compile fails.
> > > > It works if I add -D__EXTENSIONS__, but perhaps it's not the good
> > > > solution. 
> > > 
> > > can you show me the complete command line it uses while trying to compile 
> > > this file ?
> > 
> > And the actual error? I compile this fine on Solaris 2.6. I didn't
> > remember _POSIX_C_SOURCE being set normally on Solaris (which means
> > that this will succeed). You haven't set _XOPEN_SOURCE have you?
> 
> Sorry, I had a private discussion with Dirk Mueller, and we find the
> problem : I used --enable-final, and there was a #define _XOPEN_SOURCE
> in kdesu_pty.cpp ; kdesu_pty.cpp was at the beginning of the
> xxx_all_cpp.cpp file, so before the mentionned #if. 

I knew there was a reason I didn't like that #define in kdesu_pty.cpp.

I tried taking out the #define's and it seems to work fine on Solaris
and Linux. Is there some other platform this was for? Can you try
--enable-final with this?

Index: kdesu_pty.cpp
===================================================================
RCS file: /home/kde/kdelibs/kdesu/kdesu_pty.cpp,v
retrieving revision 2.7
diff -u -3 -p -r2.7 kdesu_pty.cpp
--- kdesu_pty.cpp       2001/04/11 16:48:56     2.7
+++ kdesu_pty.cpp       2001/06/28 15:51:17
@@ -15,15 +15,6 @@
  * pty.cpp: Access to PTY's on different systems a la UNIX98.
  */
 
-
-#ifndef _GNU_SOURCE
-#define _GNU_SOURCE   /* Needed for getpt, ptsname in glibc 2.1.x systems */
-#endif
-
-#if !defined(_XOPEN_SOURCE) && !defined(__osf__)
-#define _XOPEN_SOURCE /* Needed for grantpt, unlockpt in glibc 2.1.x */
-#endif
-
 #include <config.h>
 
 #include <stdio.h>
 
>> Visit http://master.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]