[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [PATCH] TCP Keepalive sending for KExtentedSocket, kio_ftp
From:       Nils Holland <nils () nightcastleproductions ! org>
Date:       2001-06-20 9:44:16
[Download RAW message or body]

On Wednesday 20 June 2001 09:39, Matthias Welwarsky wrote:
> Hi .+
>
> I've made up a _very_ preliminary patch to support enabling sending of TCP
> Keepalive packets in KExtendedSocket. The patch further implements a method
> to enable Keepalive sending in tcpslavebase based on MetaData
> (setMetaData("tcp_enable_keepalives", "TRUE"")). I have also modified the
> kio_ftp slave to enable keepalives for it's control connection. Btw, why is
> kio_ftp not based on tcpslavebase? Historical reasons, I suppose.
>
> The patch provides only limited support, e.g. the idle time and intervals
> of keepalive packets cannot be set, sending of packets cannot be disabled
> and state can not be queried yet.
>
> Also, I haven't spend any time in thinking about compatibility or
> portability, I think some additional configure checks will be needed.
> Existency of the following #defines need to be checked:
>
> SOL_TCP
> TCP_KEEPIDLE
> TCP_KEEPINTVL
>
> With glibc2.1 on linux, these can be found in netinet/tcp.h.
>
> I haven't had time to test extensively.

Hi Matze,

I applied your patches and they seemed to help. This morning, I downloaded a 
2.3 MB file unpatched and the problem was there again. After patching and 
re-compiling kdelibs, I downloaded a 4.1 MB file from the same FTP server, 
and this time the download progress box disappeared after the download was 
finished.

Note, however, that I cannot do extensive tests of this easily. After all, 
testing means downloading files of more than about 2 MB via my modem, so I 
cannot do ten test-runs in 10 minutes. However, as this first test 
demonstrated, it seems as if your patch does the right thing in fixing this 
problem.

Greetings
Nils

-- 
----------------------------------------------------------
Nils Holland - nils@nightcastleproductions.org
NightCastle Productions - Linux in Tiddische, Germany
http://www.nightcastleproductions.org
"They asked me where this earthquake would begin,
 I offered to let them feel my pulse."
----------------------------------------------------------
 
>> Visit http://master.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]