[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Kate: a Find patch
From:       Ellis Whitehead <kde () ellisw ! net>
Date:       2001-06-10 12:19:17
[Download RAW message or body]

> I'd like to see this feature in ALL "search"  dialogs.
I would too. ;)  Especially in Konqueror -- always searching from the 
beginning makes it practically impossible to find the desired occurance of a 
frequently occuring word in long html document...

May I commit?  Would I stepping on any kate-developer toes?

Ellis

> From: Ferdinand Gassauer <gassauer@kde.org>
> > Hi,
> >
> > I'd like to suggest a patch to kate's find dialog which makes the default
> > to search from the cursor position instead of from the beginning of the
> > file. This is a more 'benign' default, avoiding the user mistakenly
> > finding themselves back at a point in the document they already went
> > through.  I've been running this patch for 3 days, using kate to do most
> > of my source editing, and I have to say I like it a lot better...
>
> Hmm!
> I'd like to see this feature in ALL "search"  dialogs.
>
> > Ellis
> >
> > --------------------
> >
> > RCS file: /home/kde/kdebase/kate/view/kateview.h,v
> > retrieving revision 1.44
> > diff -r1.44 kateview.h
> > 856c856
> > <      sfFromCursor=4,
> > ---
> >
> > >      sfFromBeginning=4,
> >
> > Index: kdebase/kate/view/kateviewdialog.cpp
> > ===================================================================
> > RCS file: /home/kde/kdebase/kate/view/kateview.cpp,v
> > retrieving revision 1.79
> > diff -r1.79 kateview.cpp
> > 2222c2222
> > <   if (s.flags & KateView::sfFromCursor) {
> > ---
> >
> > >   if (!(s.flags & KateView::sfFromBeginning)) {
> >
> > 2967,2968c2967,2968
> > <   initSearch(s, (searchFlags & ((b==back)?~sfBackward:~0))  // clear
> > flag for forward searching
> > <                 | sfFromCursor | sfPrompt | sfAgain |
> > ((b!=back)?sfBackward:0) );
> > ---
> >
> > >   initSearch(s, (searchFlags & ((b==back)?~sfBackward:~0) &
> >
> > ~sfFromBeginning)  // clear flag for forward searching
> >
> > >                 | sfPrompt | sfAgain | ((b!=back)?sfBackward:0) );
> >
> > Index: kdebase/kate/view/kateview.h
> > ===================================================================
> > RCS file: /home/kde/kdebase/kate/view/kateviewdialog.cpp,v
> > retrieving revision 1.13
> > diff -r1.13 kateviewdialog.cpp
> > 79c79
> > <   m_opt3 = new QCheckBox(i18n("&From Cursor" ), group );
> > ---
> >
> > >   m_opt3 = new QCheckBox(i18n("&From Beginning" ), group );
> >
> > 90c90
> > <   m_opt3->setChecked( flags & KateView::sfFromCursor );
> > ---
> >
> > >   m_opt3->setChecked( flags & KateView::sfFromBeginning );
> >
> > 121c121
> > <   if( m_opt3->isChecked() ) flags |= KateView::sfFromCursor;
> > ---
> >
> > >   if( m_opt3->isChecked() ) flags |= KateView::sfFromBeginning;
> > >
> > >> Visit http://master.kde.org/mailman/listinfo/kde-devel#unsub to
> > >> unsubscribe <<
 
>> Visit http://master.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]