[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Adding a couple files to kdecore
From:       Lubos Lunak <l.lunak () sh ! cvut ! cz>
Date:       2001-05-30 6:26:30
[Download RAW message or body]

Dne st 30. květen 2001 07:39 Ellis Whitehead napsal(a):
> Stephan,
>
> As you suggested, I made the key/string routines static functions of
> KAccel. I've commited, but looking back at the results, I'm now even more
> uncomfortable with the functions not be separated out into their own files.
> The main reason is because there's a lot of X11 stuff in the conversion
> functions, and I don't think that anything X11-specific belongs in KAccel.
> Furthermore, some of the functions have nothing to do with the purpose of
> KAccel; for example, one which retrieves any XKeyEvent state bits which are
> always associated with a given key symbol.  And considering that the new
> code adds 300 lines to what was formerly a 600 line file...
>
> So I guess I'm asking again whether it wouldn't be better to create a new
> source and header file?
>
> Regards,
> Ellis

 I think you forgot to commit your kglobalaccel.h changes, it doesn't compile 
now.
 In kaccel.h, you have broken BC ( changed return value in 
KAccel::stringToKey() - you simply can't do that. Hint: before commiting, do 
cvs diff first and look at the changes, especially in .h files ).
 And please use kdDebug(125) ( KAccel's debug area ) instead of just plain 
kdDebug(), I think most people are not interested in e.g. getting two debug 
lines for every KAccel::stringToKey() call.

 Lubos Lunak
--
 l.lunak@email.cz ; l.lunak@kde.org
 http://dforce.sh.cvut.cz/~seli

>> Visit http://master.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]