[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [PATCH] (Was: ksize_t weirdness ..)
From:       Rob Napier <rnapier () employees ! org>
Date:       2001-04-07 18:18:05
[Download RAW message or body]

On Sat, Apr 07, 2001 at 02:31:43PM +0200, Oswald Buddenhagen wrote:
> ok ... take this! :)
> 
> i reduced the socklen_t detection a bit: don't add -Werror for g++:
> a) it's not necessary (sizeof(size_t) != sizeof(int) should always 
> lead to a "real" error, not only a warning) and
> b) checks, that work only with a certain compiler suck.
> 
> if this test still does not work, we possibly need something
> completely else ... i thought about using awk/perl to grep the
> prototype of getsockname for size_t and socklen_t. or even a run-time
> check.
> 
> NOTE: kdecore/ksocks.cpp will probably break on systems where
> sizeof(ksocklen_t) != sizeof(socklen_t), as it uses a lot of
> ksocklen_t's where socklen_t is expected. however, i'm not sure
> which way round to fix it. george?
> 
> <pedant>
> GENERAL NOTE: the right way (tm) to include config.h (i think :):
> - it should be the _very first_ include statement in a file
> - it should be quoted with <>, not ""
> </pedant>

I'm trying this patch out now on Solaris to see if it's happy. Looks
good at first brush.

Rob
 
>> Visit http://master.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]