[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [PATCH] (Was: ksize_t weirdness ..)
From:       Thiago Macieira <thiago.macieira () poli ! usp ! br>
Date:       2001-04-07 14:45:09
[Download RAW message or body]

Oswald Buddenhagen wrote:

> NOTE: kdecore/ksocks.cpp will probably break on systems where
> sizeof(ksocklen_t) != sizeof(socklen_t), as it uses a lot of
> ksocklen_t's where socklen_t is expected. however, i'm not sure
> which way round to fix it. george?

I cannot speak for George, but I think that system calls should be cast 
to socklen_t and that whatever we defined would be something consistent.

I suggested keeping ksocklen_t so that we know what that is about and 
that that has to be cast to socklen_t for the system calls. And, if in 
the future we need to change something on that again, finding ksocklen_t 
is easier than identifying what "unsigneds" are what. Think of the POSIX 
guys redefining again the meanings.


> <pedant>
> GENERAL NOTE: the right way (tm) to include config.h (i think :):
> - it should be the _very first_ include statement in a file
> - it should be quoted with <>, not ""
> </pedant>

Duly noted, but, I thought <> should be used for system headers, "" for 
local headers, even though most of the time they have the same meaning. 
That can be changed and enforced by -I- on gcc. I don't know about other 
compilers.

-- 
   Thiago Macieira - UFOT Registry number: 1001
  thiagom@mail.com talha@geocities.com
    ICQ UIN: 1967141  PGP: 0x8F2978D5 and 0xEA9037A5
      Registered Linux user #65028

13/392. You broke your little ships. -- Lily Sloane, Star Trek: First 
Contact

 
>> Visit http://master.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]