[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    kate and compiler warnings
From:       Gordon Sadler <gbsadler1 () lcisp ! com>
Date:       2001-04-07 0:25:06
[Download RAW message or body]

I realize most everyone here has probably compiles kde many more times
than I. I just thought I'd point out that most, rough guess 85-90% of
the code is 'warning clean', tracking CVS.

This is a good thing. Recently I decided to cvs update to HEAD again,
from KDE_2_1_BRANCH. So far so good. I did notice one thing... the
addition of kate, the much talked about 'replacement'? for kwrite. Ok,
so off I go to compile...

I keep a build.log (eg make 2>&1 |tee build.log) and kate seems to have
some less than average code warning wise...

grep warn build.log
katecmd.cpp:38: warning: comparison between signed and unsigned
katedocument.cpp:130: warning: unused parameter `class QObject * parent'
katedocument.cpp:130: warning: unused parameter `const char * name'
katevmallocator.cpp:116: warning: int format, off_t arg (arg 2)
katevmallocator.cpp:139: warning: int format, off_t arg (arg 2)
katebuffer.cpp:126: warning: unused parameter `int line'
katebuffer.cpp:206: warning: unused parameter `int line'
katebuffer.cpp:562: warning: unsigned int format, pointer arg (arg 2)
katebuffer.cpp:562: warning: int format, long int arg (arg 3)
katebuffer.cpp:562: warning: int format, long int arg (arg 4)
katebuffer.cpp:773: warning: int format, long int arg (arg 3)
katedialogs.cpp:272: warning: unused variable `class QPushButton *
createHl'
katedialogs.cpp:378: warning: unused variable `class QPushButton *
addContext'
katedialogs.cpp:450: warning: unused variable `bool tmpbool'
katedialogs.cpp:448: warning: unused variable `int iitem'
katedialogs.cpp:431: warning: unused variable `struct syntaxContextData
* datasub'
katedialogs.cpp:488: warning: unused variable `bool insensitive'
katedialogs.cpp:470: warning: unused parameter `class KListView * cL'
kateviewmanager.cpp:548: warning: comparison between signed and unsigned
kateviewmanager.cpp:579: warning: comparison between signed and unsigned
kateviewmanager.cpp:1014: warning: comparison between signed and
unsigned
katefilelist.cpp:39: warning: comparison between signed and unsigned
katefileselector.cpp:171: warning: comparison between signed and
unsigned
katesidebar.cpp:39: warning: unused parameter `class QWidget * widget'
katepluginmanager.cpp:78: warning: comparison between signed and
unsigned
katepluginmanager.cpp:90: warning: comparison between signed and
unsigned
katepluginmanager.cpp:101: warning: comparison between signed and
unsigned
katepluginmanager.cpp:110: warning: comparison between signed and
unsigned
katepluginmanager.cpp:140: warning: comparison between signed and
unsigned
katepluginmanager.cpp:148: warning: comparison between signed and
unsigned
katepluginmanager.cpp:150: warning: comparison between signed and
unsigned
kateconfigplugindialogpage.cpp:82: warning: comparison between signed
and unsigned
kateconfigplugindialogpage.cpp:93: warning: comparison between signed
and unsigned
kateconfigplugindialogpage.cpp:108: warning: comparison between signed
and unsigned
kateconfigplugindialogpage.cpp:124: warning: comparison between signed
and unsigned
katemain.cpp:50: warning: `class DCOPClient * client' might be used
uninitialized in this function
test.cpp:13: warning: control reaches end of non-void function
`emit(const char *)'
test.cpp:66: warning: unused variable `long int gotTen'
plugin_katetextfilter.cpp:182: warning: unused parameter `class KProcess
* pProcess'
plugin_katetextfilter.cpp:207: warning: unused parameter `class KProcess
* pProcess'
plugin_katetextfilter.cpp:102: warning: `void
slipInNewText(KateViewIface &, QString, QString, QString, bool)' defined
but not used

Some/most of the unused variables are understandable.. future uses,
debug uses, etc... but the signed/unsigned has me a bit worried. Can
lead to some awful problems later if attention is not paid now.

Thanks

Gordon Sadler
 
>> Visit http://master.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]