[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [PATCH] laptop decoration scheme should honor blend color
From:       Rob Napier <rnapier () employees ! org>
Date:       2001-04-01 6:14:06
[Download RAW message or body]

On Fri, Mar 30, 2001 at 02:27:41PM -0800, Waldo Bastian wrote:
> On Friday 30 March 2001 12:47, Rob Napier wrote:
> > I don't have CVS access, so if people like the configurable vertical
> > gradient for laptop, feel free to commit it. 
> 
> Well, I'm using it right now but to be honest I think that it violates the 
> artistic intentions that the author of the laptop style had.
> 
> I exchanged color and blend btw which makes it slightly better with the 
> default color themes imo. But still I don't think that gradients belong in 
> the laptop style, so I'm not going to commit it.

While I'm not arguing whether you should actually put this in or not,
the original author put in the gradient, not I:

(from create_pixmaps):

        aUpperGradient = new KPixmap;
        aUpperGradient->resize(32, titleHeight+2);
        iUpperGradient = new KPixmap;
        iUpperGradient->resize(32, titleHeight+2);
        QColor bgColor = options->color(Options::TitleBar, true);
        KPixmapEffect::gradient(*aUpperGradient,
                                bgColor.light(120),
                                bgColor.dark(120),
                                KPixmapEffect::VerticalGradient);

All I did was change bgColor.light and bgColor.dark to actually follow
the user-selected blend:

        aUpperGradient = new KPixmap;
        aUpperGradient->resize(32, titleHeight+2);
        iUpperGradient = new KPixmap;
        iUpperGradient->resize(32, titleHeight+2);
        QColor bgColor = options->color(Options::TitleBar, true);
        QColor blendColor = options->color(Options::TitleBlend, true);
        KPixmapEffect::gradient(*aUpperGradient,
                                bgColor,
                                blendColor,
                                KPixmapEffect::VerticalGradient);

The original blend is very subtle. This patch just lets the user
determine how subtle it is (and configure the blend color).

That said, moving a (very) subtle blend to a configurable blend may
(as you say) violate the original author's artistic intentions (which
I agree that we shouldn't do without at least the original artist's
involvement). I may just create a custom style for myself so I can get
it looking the way I want. If the final is sufficiently different from
laptop, I may put it up on kde.themes.org (they can take decorations,
can't they?)

Thanks,
Rob
 
>> Visit http://master.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]