[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [PATCH] solaris and ksocks
From:       Rob Napier <rnapier () employees ! org>
Date:       2001-03-30 20:33:34
[Download RAW message or body]

On Fri, Mar 30, 2001 at 08:48:15PM +0200, Oswald Buddenhagen wrote:
> > Do I understand you correctly, then that you recommend this:
[...]
> 
> > In ksockaddr.h, remove ksocklen_t and replace with this:
> > #ifndef socklen_t
> > typedef unsigned int socklen_t
> > #endif
> > 
> definitely not ... native socklen_t is a typedef (therefore the ifdef
> would be always true). this requires a configure test (just try the
> different versions and see if the compiler complains about a parameter
> type mismatch). so basically config.h makes the right #define, if no
> native version is available (like for size_t, etc.).
> i think, i saw this somewhere (i even thought, it's a standard test in
> autoconf but i didn't find it, so i was obviously wrong) - _maybe_, in
> the licq sources.

Can't do this. That would require putting config.h into the headers,
which is a bad thing (since users of the headers don't necessarily
have a config.h). Or so it has been explained to me. That's why we
created ksocklen_t in the first place IIRC.

Note, though, that socklen_t doesn't exist on Solaris at all AFAIK.
Wouldn't it therefore fire the #ifndef?

Rob
 
>> Visit http://master.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]