[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Whacked constants in kdelibs/kio/kdirwatch.cpp
From:       Rob Napier <rnapier () employees ! org>
Date:       2001-03-30 7:03:50
[Download RAW message or body]

Maybe 'whacked' isn't the best term, but I have no idea whose machine
this ever compiled on. Maybe Linux 2.4? But I doubt it.

There are at least the following includes missing:

#include <signal.h>
#include <stdlib.h>
#include <fcntl.h>

What is F_NOTIFY? Who does have it? On machines that don't have it,
kdirwatch is setting it to a Linux-specific constant
(F_LINUX_SPECIFIC_BASE), which I can't even find on Linux (2.2). Maybe
in the kernel headers? Haven't looked there. Any constant with a OS's
name in it, that isn't in a #ifdef specific to that OS should be
setting off alarms.

Also, to get F_SETSIG on linux 2.2 at least, you need to set
__USE_GNU. It isn't portable to other platforms, however, so probably
shouldn't be used at all (at least not without an #ifdef block).

Can we back out whatever commit this is? It probably needs to be
redone.

Thanks,
Rob
 
>> Visit http://master.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]