[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Patch to kcheckpass
From:       Oswald Buddenhagen <ob6 () inf ! tu-dresden ! de>
Date:       2001-03-30 9:12:45
[Download RAW message or body]

    
> +#if defined(sun)
> +  if ((strcmp(pw->pw_passwd, "x") == 0) ||
> +  	(pw->pw_passwd[0]=="#")) /* look up shadow */
> +#else
>    if (strcmp(pw->pw_passwd, "x") == 0) /* look up shadow */
> +#endif
>      {
> -      struct spwd *spw = getspnam(login);
> +      spw = getspnam(login);
>        if ( spw == 0 ) 
> -	return 2;
> +	return KCHECKPASS_INEXACT;
>        else password = spw->sp_pwdp;
>      }
>
i consider this code being flawed (unnecessarily complicated and fragile).
the way xdm/kdm does it:
always getspnam(), use the password from getpwnam() if getspnam() failed.
look at kdebase/kdm/greeter/verify.c and search for init_pwd.

best regards

-- 
Hi! I'm a .signature virus! Copy me into your ~/.signature, please!
--
Nothing is fool-proof to a sufficiently talented fool.
 
>> Visit http://master.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]