[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [PATCH] Re: KSocks on non-linux systems.
From:       Waldo Bastian <bastian () kde ! org>
Date:       2001-03-19 20:46:04
[Download RAW message or body]

On Monday 19 March 2001 12:16, Rob Napier wrote:
> On Mon, Mar 19, 2001 at 02:48:17PM -0500, Rob Napier wrote:
> > On Thu, Mar 15, 2001 at 12:54:01PM -0800, Waldo Bastian wrote:
> > > >From George's CVS message for those who run non-linux but don't read
> > > > kde-cvs
> > >
> > > Please:  anyone on non-linux/glibc2 platforms could you check this code
> > > and see what needs to be done to make it compile for you?  I am sure
> > > that there will be subtle libc and #include differences that need to be
> > > addressed.
> >
> > Solaris fails because socklen_t doesn't exist. The following patch
> > should fix it (compiles on Solaris, but untested; haven't tried to
> > compile on Linux).
>
> Ah crude. Doesn't quite work. The problem is on Solaris if XPG4 isn't
> defined, then this needs to be int instead of size_t (which is uint,
> so it probably "matters"). If I just set it to 'int', though, is this
> going to break other platforms? Any AIX testers?
>
> HPUX11 defines socklen_t only if _XOPEN_SOURCE_EXTENDED is set. Is
> this set for HPUX builds? I'm betting no. Otherwise these functions
> all use 'int' (just like Solaris).
>
> For the moment, I recommend changing "size_t" to "int" (corrected
> patch below) and see if that breaks anyone. The downside is that you
> won't really know whether you're having trouble unless it breaks at
> runtime, since it only throws a warning about signness being screwed
> up.
>
> Rob

There is ksize_t for exactly this purpose.

Cheers,
Waldo
-- 
bastian@kde.org | SuSE Labs KDE Developer | bastian@suse.com
 
>> Visit http://master.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]